RESOLVED FIXED 100278
Add a strategy for loader customization 
https://bugs.webkit.org/show_bug.cgi?id=100278
Summary Add a strategy for loader customization
Brady Eidson
Reported 2012-10-24 12:23:18 PDT
Add a strategy for loader customization. Just empty for now. Will be used to customize loader behavior in the near future.
Attachments
Patch v1 (28.96 KB, patch)
2012-10-24 12:29 PDT, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-10-24 12:29:50 PDT
Created attachment 170447 [details] Patch v1
WebKit Review Bot
Comment 2 2012-10-24 12:32:49 PDT
Attachment 170447 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.h:31: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2012-10-24 12:33:49 PDT
Comment on attachment 170447 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=170447&action=review r=me, please wait for EWS. I can feel you conflict-merging pain. > Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.h:31 > +class PlatformStrategiesEfl : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::LoaderStrategy,private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::VisitedLinkStrategy { Space before comma.
Brady Eidson
Comment 4 2012-10-24 12:39:58 PDT
Definitely waiting on EWS. Thanks for the review.
Brady Eidson
Comment 5 2012-10-24 13:50:54 PDT
http://trac.webkit.org/changeset/132396
Note You need to log in before you can comment on or make changes to this bug.