Bug 100278 - Add a strategy for loader customization
Summary: Add a strategy for loader customization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-24 12:23 PDT by Brady Eidson
Modified: 2012-10-24 13:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch v1 (28.96 KB, patch)
2012-10-24 12:29 PDT, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-10-24 12:23:18 PDT 
Add a strategy for loader customization.

Just empty for now.  Will be used to customize loader behavior in the near future.
Comment 1 Brady Eidson 2012-10-24 12:29:50 PDT 
Created attachment 170447 [details]
Patch v1
Comment 2 WebKit Review Bot 2012-10-24 12:32:49 PDT 
Attachment 170447 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.h:31:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2012-10-24 12:33:49 PDT 
Comment on attachment 170447 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=170447&action=review

r=me, please wait for EWS. I can feel you conflict-merging pain.

> Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.h:31
> +class PlatformStrategiesEfl : public WebCore::PlatformStrategies, private WebCore::CookiesStrategy, private WebCore::LoaderStrategy,private WebCore::PluginStrategy, private WebCore::SharedWorkerStrategy, private WebCore::VisitedLinkStrategy {

Space before comma.
Comment 4 Brady Eidson 2012-10-24 12:39:58 PDT 
Definitely waiting on EWS.  Thanks for the review.
Comment 5 Brady Eidson 2012-10-24 13:50:54 PDT 
http://trac.webkit.org/changeset/132396