Bug 100258 - BlackBerry fix for webgl-depth-texture.html
Summary: BlackBerry fix for webgl-depth-texture.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-24 08:48 PDT by Jonathan Feldstein
Modified: 2012-10-24 13:16 PDT (History)
6 users (show)

See Also:


Attachments
Patch (753 bytes, patch)
2012-10-24 10:31 PDT, Jonathan Feldstein
no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2012-10-24 10:50 PDT, Jonathan Feldstein
no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2012-10-24 12:15 PDT, Jonathan Feldstein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Feldstein 2012-10-24 08:48:45 PDT
webgl-depth-texture.html is a WebGL conformance suite test that is partially failing on the BlackBerry platform. We need to upstream a fix for this.
Comment 1 Jonathan Feldstein 2012-10-24 10:31:47 PDT
Created attachment 170425 [details]
Patch
Comment 2 Jonathan Feldstein 2012-10-24 10:50:51 PDT
Created attachment 170428 [details]
Patch
Comment 3 Yong Li 2012-10-24 11:57:45 PDT
Comment on attachment 170428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170428&action=review

> Source/WebCore/ChangeLog:11
> +
> +        No new tests (OOPS!).
> +

Please change this line with some short explanation. Patch with (OOPS!) in changelog cannot get committed

> Source/WebCore/platform/graphics/GraphicsContext3D.cpp:-121
> -#if !PLATFORM(BLACKBERRY)
>      case GraphicsContext3D::UNSIGNED_INT_24_8:
> -#endif

any idea about why we did this before?
Comment 4 Jonathan Feldstein 2012-10-24 12:10:54 PDT
(In reply to comment #3)
> (From update of attachment 170428 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170428&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +
> > +        No new tests (OOPS!).
> > +
> 
> Please change this line with some short explanation. Patch with (OOPS!) in changelog cannot get committed
> 
> > Source/WebCore/platform/graphics/GraphicsContext3D.cpp:-121
> > -#if !PLATFORM(BLACKBERRY)
> >      case GraphicsContext3D::UNSIGNED_INT_24_8:
> > -#endif
> 
> any idea about why we did this before?

I spoke with a few other people and no one came up with a good reason. Worst case instead of returning false we'd eventually cause a gl error for an invalid enum. Not that that should happen anyways.

I'll add you as the reviewer at the same time as removing the no new tests line.
Comment 5 Jonathan Feldstein 2012-10-24 12:15:09 PDT
Created attachment 170444 [details]
Patch
Comment 6 Yong Li 2012-10-24 12:51:53 PDT
Comment on attachment 170444 [details]
Patch

seems this code was added for build fix... so I assume we can build with UNSIGNED_INT_24_8 now.
Comment 7 WebKit Review Bot 2012-10-24 13:16:09 PDT
Comment on attachment 170444 [details]
Patch

Clearing flags on attachment: 170444

Committed r132387: <http://trac.webkit.org/changeset/132387>
Comment 8 WebKit Review Bot 2012-10-24 13:16:12 PDT
All reviewed patches have been landed.  Closing bug.