Bug 100243 - [EFL] run-webkit-tests writes garbage on stderr when running on Xvfb
Summary: [EFL] run-webkit-tests writes garbage on stderr when running on Xvfb
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-24 06:31 PDT by Thiago Marcos P. Santos
Modified: 2012-10-24 07:34 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.13 KB, patch)
2012-10-24 06:43 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff
Patch (7.30 KB, patch)
2012-10-24 06:51 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-10-24 06:31:59 PDT
run-webkit-tests runs using the Xvfb driver on the EFL bots. (example: Xlib:  extension "DPMS" missing on display ":4".)

These errors generate noise on the reports and in some cases, like when running perf tests, makes the test fail.
Comment 1 Thiago Marcos P. Santos 2012-10-24 06:43:00 PDT
Created attachment 170382 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-24 06:45:52 PDT
Attachment 170382 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit2/ChangeLog', u..." exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Thiago Marcos P. Santos 2012-10-24 06:51:22 PDT
Created attachment 170383 [details]
Patch
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-10-24 06:58:53 PDT
Comment on attachment 170383 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2012-10-24 07:33:59 PDT
Comment on attachment 170383 [details]
Patch

Clearing flags on attachment: 170383

Committed r132350: <http://trac.webkit.org/changeset/132350>
Comment 6 WebKit Review Bot 2012-10-24 07:34:04 PDT
All reviewed patches have been landed.  Closing bug.