Bug 100239 - [Qt] Expose useful WebCore::Settings
Summary: [Qt] Expose useful WebCore::Settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-24 05:30 PDT by Allan Sandfeld Jensen
Modified: 2012-10-24 06:41 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.23 KB, patch)
2012-10-24 05:33 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-10-24 05:30:34 PDT
Going through the available settings in WebCore, I found at least two useful ones I think we should expose to our users.

CaretBrowsing: A mode where the page acts like read-only editable content. This means it only scrolls when the caret leaves the page. This mode has its fans.
Notifications: The HTML5 notifications, they are enabled by default, but some users might want to disable them.
Comment 1 Allan Sandfeld Jensen 2012-10-24 05:33:16 PDT
Created attachment 170375 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-24 05:35:13 PDT
Attachment 170375 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qwebsettings.cpp', u'..." exit_code: 1
Source/WebKit/qt/Api/qwebsettings.cpp:271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/qt/Api/qwebsettings.cpp:275:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2012-10-24 06:41:42 PDT
Comment on attachment 170375 [details]
Patch

Clearing flags on attachment: 170375

Committed r132345: <http://trac.webkit.org/changeset/132345>
Comment 4 WebKit Review Bot 2012-10-24 06:41:45 PDT
All reviewed patches have been landed.  Closing bug.