Bug 100231 - CSS3 Media Queries - add resolution tests to W3C test suite
Summary: CSS3 Media Queries - add resolution tests to W3C test suite
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Shalamov
Depends on:
Blocks: 78087
  Show dependency treegraph
Reported: 2012-10-24 04:38 PDT by Alexander Shalamov
Modified: 2012-10-24 07:38 PDT (History)
8 users (show)

See Also:

Patch 1 (4.77 KB, patch)
2012-10-24 04:48 PDT, Alexander Shalamov
kenneth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch 2 (93.20 KB, patch)
2012-10-24 07:03 PDT, Alexander Shalamov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Shalamov 2012-10-24 04:38:49 PDT
Resolution tests were removed, since implementation was missing.
Since resolution feature was added recently, tests could be added back.
Comment 1 Alexander Shalamov 2012-10-24 04:48:22 PDT
Created attachment 170365 [details]
Patch 1

- Added resolution media feature tests to W3C Media Queries test suite
Comment 2 Kenneth Rohde Christiansen 2012-10-24 04:59:13 PDT
Comment on attachment 170365 [details]
Patch 1

Not all platforms will pass with this and they will need different results. How do you intent to rebase that? After this lands?
Comment 3 WebKit Review Bot 2012-10-24 05:36:53 PDT
Comment on attachment 170365 [details]
Patch 1

Attachment 170365 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14566184

New failing tests:
Comment 4 Alexander Shalamov 2012-10-24 07:03:42 PDT
Created attachment 170389 [details]
Patch 2

- Added platform specific test expectations to blackberry, chromium, mac, win and gtk ports
- Added assert_false and assert_true wrappers, so that stack trace is not shown when the test is failed
Comment 5 WebKit Review Bot 2012-10-24 07:38:24 PDT
Comment on attachment 170389 [details]
Patch 2

Clearing flags on attachment: 170389

Committed r132352: <http://trac.webkit.org/changeset/132352>
Comment 6 WebKit Review Bot 2012-10-24 07:38:29 PDT
All reviewed patches have been landed.  Closing bug.