Bug 100230 - [EFL][WK2] Get rid of Ewk_View private C API (Part 1)
Summary: [EFL][WK2] Get rid of Ewk_View private C API (Part 1)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 100228
Blocks: 100226 100273 100331
  Show dependency tree / graph
 
Reported: 2012-10-24 04:38 PDT by Chris Dumez
Modified: 2012-10-25 07:00 PDT (History)
9 users (show)

See Also:

Attachments
Patch (151.34 KB, patch)
2012-10-24 11:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (150.55 KB, patch)
2012-10-24 12:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-24 04:38:37 PDT 
As part of the Ewk_View refactoring (Bug 100226), we are planning to get rid of the Ewk_View private C API.

This private C API will be replaced by C++ methods in the new EwkViewImpl class (Bug 99696).
Comment 1 Chris Dumez 2012-10-24 04:39:27 PDT 
(In reply to comment #0)
> As part of the Ewk_View refactoring (Bug 100226), we are planning to get rid of the Ewk_View private C API.
> 
> This private C API will be replaced by C++ methods in the new EwkViewImpl class (Bug 99696).

The new EwkViewImpl class is Bug 100228, not 99696. Sorry.
Comment 2 Chris Dumez 2012-10-24 10:51:00 PDT 
I will do this in 2 parts (at least) because it gets too big otherwise and it would become a rebasing nightmare.
Comment 3 Chris Dumez 2012-10-24 11:25:11 PDT 
Created attachment 170436 [details]
Patch
Comment 4 Kenneth Rohde Christiansen 2012-10-24 12:25:11 PDT 
Comment on attachment 170436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170436&action=review

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:39
> +#define EWK_VIEW_IMPL_GET(smartData, viewImpl)                                 \
> +    EwkViewImpl* viewImpl = smartData->priv

why not just call it impl?

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:127
> +    void reportDownloadJobCancelled(Ewk_Download_Job* download);
> +    void reportDownloadJobFailed(Ewk_Download_Job* download, Ewk_Error* error);
> +    void reportDownloadJobFinished(Ewk_Download_Job* download);
> +    void reportDownloadJobRequested(Ewk_Download_Job* download);
> +

I dont like report :-) why not inform ? :) report sounds like logging to me
Comment 5 Chris Dumez 2012-10-24 12:47:40 PDT 
Created attachment 170452 [details]
Patch

Take Kenneth's feedback into consideration.
Comment 6 WebKit Review Bot 2012-10-24 14:52:10 PDT 
Comment on attachment 170452 [details]
Patch

Clearing flags on attachment: 170452

Committed r132405: <http://trac.webkit.org/changeset/132405>
Comment 7 WebKit Review Bot 2012-10-24 14:52:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Antonio Gomes 2012-10-25 07:00:26 PDT 
(In reply to comment #4)
> (From update of attachment 170436 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170436&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:39
> > +#define EWK_VIEW_IMPL_GET(smartData, viewImpl)                                 \
> > +    EwkViewImpl* viewImpl = smartData->priv
> 
> why not just call it impl?
> 
> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:127
> > +    void reportDownloadJobCancelled(Ewk_Download_Job* download);
> > +    void reportDownloadJobFailed(Ewk_Download_Job* download, Ewk_Error* error);
> > +    void reportDownloadJobFinished(Ewk_Download_Job* download);
> > +    void reportDownloadJobRequested(Ewk_Download_Job* download);
> > +
> 
> I dont like report :-) why not inform ? :) report sounds like logging to me

Notify?