Bug 100214 - [BlackBerry] ASSERT(!needsOneShotDrawingSynchronization()) failed in commitRootLayerIfNeeded()
Summary: [BlackBerry] ASSERT(!needsOneShotDrawingSynchronization()) failed in commitRo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-24 01:31 PDT by Sean Wang
Modified: 2012-10-24 20:42 PDT (History)
5 users (show)

See Also:


Attachments
patch (3.33 KB, patch)
2012-10-24 01:49 PDT, Sean Wang
rwlbuis: review+
Details | Formatted Diff | Diff
Improved patch (3.45 KB, patch)
2012-10-24 19:12 PDT, Sean Wang
no flags Details | Formatted Diff | Diff
Patch added "Reviewed by Rob Buis" (3.43 KB, patch)
2012-10-24 19:23 PDT, Sean Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Wang 2012-10-24 01:31:04 PDT
DESCRIPTION:
Assertion failed when I open the tab bar when loading the test case page.

HOW TO REPRODUCE:
Build webkit repo with debug configuration.
Open the test case in the attachment, when it loaded, open the tab bar.

EXPECTED:
The webpage is hide and the tab bar is shown.

ACTUAL:
An assertion failed with the stack of following

Thread [3] (Suspended: Signal 'SIGSEGV' received. Description: Segmentation
fault.)
        20 BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded()
WebPage.cpp:5670 0x78eedab8
        19
BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates()
BackingStore.cpp:362 0x78eac2c8
        18 BlackBerry::WebKit::WebPagePrivate::setViewportSize()
WebPage.cpp:3861 0x78ee5bc8
        17 BlackBerry::WebKit::WebPage::setViewportSize() WebPage.cpp:3891
0x78ee5d38
Comment 1 Sean Wang 2012-10-24 01:49:48 PDT
Created attachment 170344 [details]
patch
Comment 2 Rob Buis 2012-10-24 07:47:02 PDT
Comment on attachment 170344 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170344&action=review

Looks good. Please consider adding PR number and the internal reviewer before landing.

> Source/WebKit/blackberry/ChangeLog:14
> +

Unneeded empty line here.
Comment 3 Sean Wang 2012-10-24 19:12:23 PDT
Created attachment 170537 [details]
Improved patch

I added internal reviewer and PR number.
Comment 4 Sean Wang 2012-10-24 19:23:39 PDT
Created attachment 170538 [details]
Patch added "Reviewed by Rob Buis"
Comment 5 Charles Wei 2012-10-24 19:26:37 PDT
Comment on attachment 170538 [details]
Patch added "Reviewed by Rob Buis"

Already reviewed by Rob. Commit it.
Comment 6 WebKit Review Bot 2012-10-24 20:42:12 PDT
Comment on attachment 170538 [details]
Patch added "Reviewed by Rob Buis"

Clearing flags on attachment: 170538

Committed r132443: <http://trac.webkit.org/changeset/132443>
Comment 7 WebKit Review Bot 2012-10-24 20:42:15 PDT
All reviewed patches have been landed.  Closing bug.