Bug 100205 – Fix CALayer hiearchy when combining tiling with preserve-3d

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Fix CALayer hiearchy when combining tiling with preserve-3d

[Simon Fraser (smfr)]

Created attachment 170326 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/12557752>

[WebKit Review Bot]

Comment on attachment 170326 [details]
Patch

Attachment 170326 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14552186

New failing tests:
platform/chromium/virtual/softwarecompositing/tiling/backface-preserve-3d-tiled.html
compositing/tiling/backface-preserve-3d-tiled.html

[Dean Jackson]

Comment on attachment 170326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170326&action=review

> Source/WebCore/ChangeLog:25
> +        Test: compositing/tiling/backface-preserve-3d-tiled.html

Does the chrome failure just get baselined at some later stage?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1192
> +    PlatformCALayerList& childListForSublayers = m_structuralLayer ? structuralLayerChildren : primaryLayerChildren;

It might be a bit clearer if you move this line down to in front of the loop where you actually use it, but not a strong opinion.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1205
> +    if (m_contentsLayer && m_contentsVisible)
> +        primaryLayerChildren.append(m_contentsLayer);

Does the FIXME you removed still apply?

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/132394