Bug 100204 - AX: WebKit exposes abstract ARIA role range as AXSlider; should be generic AXGroup
Summary: AX: WebKit exposes abstract ARIA role range as AXSlider; should be generic AX...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-10-23 23:22 PDT by chris fleizach
Modified: 2012-10-25 11:03 PDT (History)
3 users (show)

See Also:


Attachments
patch (7.53 KB, patch)
2012-10-23 23:30 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (7.51 KB, patch)
2012-10-24 08:15 PDT, chris fleizach
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2012-10-23 23:22:30 PDT
WebKit exposes abstract ARIA role range as AXSlider; should be generic AXGroup

1. https://dvcs.w3.org/hg/pfwg/raw-file/tip/ARIA/1.0/tests/test-files/roles-plain-abstract/roles-plain-abstract-range.html

The <div role="range">  element is exposed as the *abstract* ARIA role range which is the parent role for both slider and spinbutton.

Note: the HTML element type is "range" (<input type="range") and is equivalent to ARIA slider (<div role="slider") so this is probably where the confusion started. Both of these should remain as AXSlider.

It's only the ROLE of "range" that is exposed incorrectly. Since it's abstract, it should be exposed as a generic AXGroup.
Comment 1 chris fleizach 2012-10-23 23:22:38 PDT
rdar://12085957
Comment 2 chris fleizach 2012-10-23 23:30:13 PDT
Created attachment 170324 [details]
patch
Comment 3 Dominic Mazzoni 2012-10-24 00:01:44 PDT
Unofficial review - looks good. Can you move the test to the main directory rather than platform/mac, though? It should pass on Chromium and GTK now, especially with the latest GTK refactoring.
Comment 4 chris fleizach 2012-10-24 08:15:52 PDT
Created attachment 170403 [details]
patch

Moved the test to /accessibility
Comment 5 chris fleizach 2012-10-24 12:03:40 PDT
http://trac.webkit.org/changeset/132381
Moved that test to the top level accessibility folder too
Comment 6 Roger Fong 2012-10-25 10:57:45 PDT
Is accessibility/aria-slider-value.html  another test that should be skipped on Windows or get Windows specific results?
Comment 7 chris fleizach 2012-10-25 11:00:05 PDT
(In reply to comment #6)
> Is accessibility/aria-slider-value.html  another test that should be skipped on Windows or get Windows specific results?

that's a good question. has the windows platform mapped "slider" to the appropriate role? I don't know. My guess is that that test should be skipped on windows
Comment 8 Roger Fong 2012-10-25 11:03:39 PDT
Ah yes, I'm remembering now from previous test failures that none of the "role stuff" works on windows, I'll skip it.