Bug 100183 - encode should take an ArgumentEncoder reference
Summary: encode should take an ArgumentEncoder reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-23 19:56 PDT by Anders Carlsson
Modified: 2012-10-24 09:18 PDT (History)
9 users (show)

See Also:

Attachments
Patch (107.43 KB, patch)
2012-10-23 20:00 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (108.18 KB, patch)
2012-10-23 20:11 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (135.93 KB, patch)
2012-10-23 20:26 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (136.14 KB, patch)
2012-10-23 20:54 PDT, Anders Carlsson 		jberlin: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-10-23 19:56:10 PDT 
encode should take an ArgumentEncoder reference
Comment 1 Anders Carlsson 2012-10-23 20:00:26 PDT 
Created attachment 170297 [details]
Patch
Comment 2 Anders Carlsson 2012-10-23 20:11:12 PDT 
Created attachment 170298 [details]
Patch
Comment 3 Andreas Kling 2012-10-23 20:17:27 PDT 
Comment on attachment 170298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170298&action=review

rs=me

> Source/WebKit2/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

OOPS!
Comment 4 EFL EWS Bot 2012-10-23 20:25:56 PDT 
Comment on attachment 170298 [details]
Patch

Attachment 170298 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14562014
Comment 5 Anders Carlsson 2012-10-23 20:26:12 PDT 
Created attachment 170299 [details]
Patch
Comment 6 Andreas Kling 2012-10-23 20:36:02 PDT 
Comment on attachment 170299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170299&action=review

Rubberstamp still stands.

> Source/WebKit2/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

OOPS!!!i1i!I!99q
Comment 7 WebKit Review Bot 2012-10-23 20:37:19 PDT 
Attachment 170299 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/Shared/win/PlatformCertificateInfo.h:54:  The parameter name "encoder" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 128 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Build Bot 2012-10-23 20:40:32 PDT 
Comment on attachment 170298 [details]
Patch

Attachment 170298 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14563026
Comment 9 Build Bot 2012-10-23 20:54:18 PDT 
Comment on attachment 170299 [details]
Patch

Attachment 170299 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14563033
Comment 10 Anders Carlsson 2012-10-23 20:54:38 PDT 
Created attachment 170304 [details]
Patch
Comment 11 WebKit Review Bot 2012-10-23 20:57:21 PDT 
Attachment 170304 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/Shared/win/PlatformCertificateInfo.h:54:  The parameter name "encoder" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 128 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Jessie Berlin 2012-10-24 08:37:21 PDT 
Comment on attachment 170304 [details]
Patch

r=me assuming you fix the style error.
Comment 13 Anders Carlsson 2012-10-24 09:18:41 PDT 
Committed r132361: <http://trac.webkit.org/changeset/132361>