Bug 100182 – Fix windowRect calculation for webplugin due to page scale factors

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Min Qin]

Fix windowRect calculation for webplugin due to page scale factors

[Min Qin]

Created attachment 170296 [details]
Patch

[Adam Barth]

Comment on attachment 170296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170296&action=review

> Source/WebKit/chromium/ChangeLog:12
> +        No test for this as the code for page scale factor will soon be deprecated.

Can we add tests that will continue to pass even after we deprecate page scale factor?  If this code is worth changing, it is worth writing tests for.

[Min Qin]

I am looking into adding a layout test for this, but the TestWebPlugin failed miserably on this case. 
Whenever I put a x-webkit-test-webplugin in an iframe, i got a context lost error when running the layout test. I will take a look into this

[Alexandre Elias]

Hi Adam, this is difficult to write a test for because it's pixel-based, and plugin placeholder is managed on the Chromium side (so we can't make it render in a layout test).  Could we land without test?

[Adam Barth]

Comment on attachment 170296 [details]
Patch

Ok.  Can you change the explanation in the ChangeLog entry?  That's a much better reason than the code being deprecated soon.  :)

[Min Qin]

Created attachment 173706 [details]
Patch

[Min Qin]

Done, ChangeLog updated.

(In reply to comment #5)
> (From update of attachment 170296 [details])
> Ok.  Can you change the explanation in the ChangeLog entry?  That's a much better reason than the code being deprecated soon.  :)

[Adam Barth]

Comment on attachment 173706 [details]
Patch

Thanks.

[WebKit Review Bot]

Comment on attachment 173706 [details]
Patch

Rejecting attachment 173706 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14809620

[WebKit Review Bot]

Comment on attachment 173706 [details]
Patch

Clearing flags on attachment: 173706

Committed r134334: <http://trac.webkit.org/changeset/134334>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.