RESOLVED FIXED 100180
Stop using NSHomeDirectory() to get the home directory, it doesn't always return what we want 
https://bugs.webkit.org/show_bug.cgi?id=100180
Summary Stop using NSHomeDirectory() to get the home directory, it doesn't always ret...
Sam Weinig
Reported 2012-10-23 19:17:22 PDT
Stop using NSHomeDirectory() to get the home directory, it doesn't always return what we want
Attachments
Patch (4.14 KB, patch)
2012-10-23 19:19 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-10-23 19:19:10 PDT
Created attachment 170293 [details] Patch
Anders Carlsson
Comment 2 2012-10-23 19:22:36 PDT
Comment on attachment 170293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170293&action=review > Source/WebKit2/WebProcess/mac/WebProcessMac.mm:214 > + int bufferSize = 4096; > + char buffer[4096]; Please write this as char buffer[4096]; int bufferSize = sizeof(buffer);
Sam Weinig
Comment 3 2012-10-23 19:53:12 PDT
Committed r132294: <http://trac.webkit.org/changeset/132294>
Darin Adler
Comment 4 2012-10-24 07:58:02 PDT
Comment on attachment 170293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170293&action=review >> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:214 >> + char buffer[4096]; > > Please write this as > > char buffer[4096]; > int bufferSize = sizeof(buffer); Is 4096 better than PATH_MAX or MAXPATHLEN?
Note You need to log in before you can comment on or make changes to this bug.