Bug 100171 - [Mac] Sync up FeatureDefine Configuration Files
Summary: [Mac] Sync up FeatureDefine Configuration Files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-23 16:18 PDT by Joseph Pecoraro
Modified: 2012-10-30 16:51 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed Patch (30.19 KB, patch)
2012-10-23 16:27 PDT, Joseph Pecoraro
ddkilzer: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Follow-up For Better iOS Coordination (20.95 KB, patch)
2012-10-23 16:50 PDT, Joseph Pecoraro
ddkilzer: review+
joepeck: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2012-10-23 16:18:17 PDT
Some features are enabled only in one of the project configurations files, etc. The files should
be identical to avoid accidents and unexpected build issues.

I'll follow with some patches.
Comment 1 Joseph Pecoraro 2012-10-23 16:27:40 PDT
Created attachment 170266 [details]
[PATCH] Proposed Patch

Make the configuration file identical across all projects.
Comment 2 Joseph Pecoraro 2012-10-23 16:50:50 PDT
Created attachment 170268 [details]
[PATCH] Follow-up For Better iOS Coordination

Some of these features are disabled for iOS but enabled for iOS. Make those _macosx only. And other cleanup.

cq- on these because this one depends on the first landing, and I don't think the cq works well with multiple patches on a bug.
Comment 3 David Kilzer (:ddkilzer) 2012-10-26 11:08:36 PDT
Comment on attachment 170266 [details]
[PATCH] Proposed Patch

r=me
Comment 4 David Kilzer (:ddkilzer) 2012-10-26 11:09:57 PDT
Comment on attachment 170268 [details]
[PATCH] Follow-up For Better iOS Coordination

r=me
Comment 5 Joseph Pecoraro 2012-10-30 16:51:17 PDT
First part landed in r132958:
<http://trac.webkit.org/changeset/132958>

Second part landed in r132963:
<http://trac.webkit.org/changeset/132963>