Bug 100165 – Add a strategy for shared workers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alexey Proskuryakov]

Just an empty one for now. Will be used to create a worker process when appropriate.

[Alexey Proskuryakov]

Created attachment 170252 [details]
proposed patch

Since bug 100031 wasn't such a great idea, this is a lot of copy/pasted code.

[Brady Eidson]

A lot of the copy/paste into the WebKit1 ports could be avoided by adding a default strategy to WebCore.  This is something I currently have in my working tree for the strategy I'm considering adding soon... thoughts?

[Early Warning System Bot]

Comment on attachment 170252 [details]
proposed patch

Attachment 170252 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14525126

[Alexey Proskuryakov]

That would save some effort, but it would be quite a layering violation.

Having PlatformStrategies know the names of non-platform classes is one thing - we can think of it as a universal connector. But directly including them is certainly wrong.

[Alexey Proskuryakov]

Created attachment 170257 [details]
with Qt copy-pasta fixed

[Brady Eidson]

(In reply to comment #4)
> That would save some effort, but it would be quite a layering violation.
> 
> Having PlatformStrategies know the names of non-platform classes is one thing - we can think of it as a universal connector. But directly including them is certainly wrong.

I was thinking to *not* have individual strategies be in WebCore/Platform.

Imagine if PluginStrategy.h/cpp were in WebCore/Plugins, as an example.  All PlatformStrategies.h/cpp would do would provide access to the default PluginStrategy for those platforms that don't need different behavior...  that's what I was thinking.

Does that sound as bad?

[Early Warning System Bot]

Comment on attachment 170257 [details]
with Qt copy-pasta fixed

Attachment 170257 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14539042

[EFL EWS Bot]

Comment on attachment 170257 [details]
with Qt copy-pasta fixed

Attachment 170257 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14505630

[Brady Eidson]

We chatted in person.

I'll review after EWS has been pleased.

[Alexey Proskuryakov]

Created attachment 170274 [details]
more Qt fixing

Not sure how to fix EFL. Grepped everywhere trying to find how it finds PluginStrategy.h for comparison, but couldn't find that.

[EFL EWS Bot]

Comment on attachment 170274 [details]
more Qt fixing

Attachment 170274 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14543024

[Alexey Proskuryakov]

Could someone working on EFL please help with this build failure?

[Brady Eidson]

Does EFL have workers enabled?

[Chris Dumez]

(In reply to comment #13)
> Does EFL have workers enabled?

Yes, we do have worker enabled:
Source/cmake/OptionsEfl.cmake:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SHARED_WORKERS ON)
Source/cmake/OptionsEfl.cmake:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WORKERS ON)

[Chris Dumez]

I'm looking into it.

[Chris Dumez]

This will fix the EFL build:

diff --git a/Source/WebKit/CMakeLists.txt b/Source/WebKit/CMakeLists.txt
index a7983d9..5d0e361 100644
--- a/Source/WebKit/CMakeLists.txt
+++ b/Source/WebKit/CMakeLists.txt
@@ -43,6 +43,7 @@ SET(WebKit_INCLUDE_DIRECTORIES
     "${WEBCORE_DIR}/svg"
     "${WEBCORE_DIR}/svg/graphics"
     "${WEBCORE_DIR}/svg/properties"
+    "${WEBCORE_DIR}/workers"
     "${JAVASCRIPTCORE_DIR}"
     "${JAVASCRIPTCORE_DIR}/ForwardingHeaders"
     "${JAVASCRIPTCORE_DIR}/API"

[Alexey Proskuryakov]

Created attachment 170331 [details]
with EFL build fix

Thank you so much!

Build fix included, let's see how happy EWS is.

[Brady Eidson]

Comment on attachment 170331 [details]
with EFL build fix

EFL passed, yay!

[WebKit Review Bot]

Comment on attachment 170331 [details]
with EFL build fix

Rejecting attachment 170331 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 12787.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14569231

[Alexey Proskuryakov]

Committed manually: http://trac.webkit.org/changeset/132367