Bug 100160 - Remove Chromium specific expectations for video-media-source-add-and-remove-buffers.html
Summary: Remove Chromium specific expectations for video-media-source-add-and-remove-b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aaron Colwell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-23 14:38 PDT by Aaron Colwell
Modified: 2012-10-26 14:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.95 KB, patch)
2012-10-23 14:44 PDT, Aaron Colwell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Colwell 2012-10-23 14:38:37 PDT 
There was an error in the original expectations for http/tests/media/media-source/video-media-source-add-and-remove-buffers.html. When http://crbug.com/155226 was fixed it caused the LayoutTest to started failing because the existing expectations were just capturing the old incorrect behavior. The Chromium WebKit gardener created Chromium specific expectations to compensate for the failed test (http://trac.webkit.org/changeset/131086). 

The attached patch will remove the Chromium specific expectations and update the common expectations to reflect the correct behavior.
Comment 1 Aaron Colwell 2012-10-23 14:44:23 PDT 
Created attachment 170238 [details]
Patch
Comment 2 Aaron Colwell 2012-10-26 12:32:48 PDT 
abarth@ can I get a quick review please.
Comment 3 Adam Barth 2012-10-26 14:16:17 PDT 
Comment on attachment 170238 [details]
Patch

Great!
Comment 4 WebKit Review Bot 2012-10-26 14:26:07 PDT 
Comment on attachment 170238 [details]
Patch

Clearing flags on attachment: 170238

Committed r132694: <http://trac.webkit.org/changeset/132694>
Comment 5 WebKit Review Bot 2012-10-26 14:26:10 PDT 
All reviewed patches have been landed.  Closing bug.