Bug 100158 - popup menus don't behave correctly when using multiple monitors
Summary: popup menus don't behave correctly when using multiple monitors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-23 13:40 PDT by Roger Fong
Modified: 2012-11-28 11:36 PST (History)
2 users (show)

See Also:

Attachments
patch (1.28 KB, patch)
2012-10-23 13:54 PDT, Roger Fong 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2012-10-23 13:40:24 PDT 
Need to add screen.x() to the popup menu position check to account for having multiple monitors.
Comment 1 Roger Fong 2012-10-23 13:54:19 PDT 
Created attachment 170229 [details]
patch
Comment 2 Tim Horton 2012-10-23 14:27:41 PDT 
Comment on attachment 170229 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170229&action=review

> Source/WebCore/ChangeLog:7
> +

A few more words here would be nice.

> Source/WebCore/ChangeLog:8
> +        * platform/win/PopupMenuWin.cpp:

You should say why this isn’t testable (No new tests because...)
Comment 3 Tim Horton 2012-11-28 11:36:00 PST 
http://trac.webkit.org/changeset/132271