CLOSED FIXED 100145
[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to Generic ThreadUnsafe Singleton 
https://bugs.webkit.org/show_bug.cgi?id=100145
Summary [BlackBerry] Extending existing ThreadUnsafe singletons in webkit to Generic ...
Parth Patel
Reported 2012-10-23 10:57:18 PDT
Making thread unsafe singleton in webkit extend the generic thread unsafe singleton present in BlackBerryPlatformSingleton.
Attachments
Patch (6.36 KB, patch)
2012-10-24 07:01 PDT, Parth Patel 		no flags
DetailsFormatted DiffDiff
Patch (6.33 KB, patch)
2012-10-24 07:34 PDT, Parth Patel 		no flags
DetailsFormatted DiffDiff
Patch (6.29 KB, patch)
2012-10-24 07:54 PDT, Parth Patel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Parth Patel
Comment 1 2012-10-24 07:01:31 PDT
Created attachment 170386 [details] Patch
WebKit Review Bot
Comment 2 2012-10-24 07:06:56 PDT
Attachment 170386 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h:34: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Parth Patel
Comment 3 2012-10-24 07:34:08 PDT
Created attachment 170391 [details] Patch
Rob Buis
Comment 4 2012-10-24 07:41:19 PDT
Comment on attachment 170391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170391&action=review Please fix the Changelogs. > Source/WebCore/ChangeLog:7 > + Reviewed by: Yong Li. This is ot how we do it. It is better to keep the original Reviewed by (OOPS)!!! line here. What you should do is an extra line with "Reviewed internally by XXX". Have a look at our other commits. > Source/WebCore/ChangeLog:12 > + https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=214384 You can just abbreviate to PR214384. > Source/WebKit/blackberry/ChangeLog:7 > + Reviewed by: Yong Li. Ditto. > Source/WebKit/blackberry/ChangeLog:12 > + https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=214384 Ditto.
Parth Patel
Comment 5 2012-10-24 07:54:12 PDT
Created attachment 170395 [details] Patch
Rob Buis
Comment 6 2012-10-24 07:59:30 PDT
Comment on attachment 170395 [details] Patch LGTM.
WebKit Review Bot
Comment 7 2012-10-24 08:28:39 PDT
Comment on attachment 170395 [details] Patch Clearing flags on attachment: 170395 Committed r132358: <http://trac.webkit.org/changeset/132358>
WebKit Review Bot
Comment 8 2012-10-24 08:28:43 PDT
All reviewed patches have been landed. Closing bug.
Yong Li
Comment 9 2012-10-26 08:46:47 PDT
close
Note You need to log in before you can comment on or make changes to this bug.