Bug 100126 – [EFL] Add baselines for non problematic tests in editing subcategories: deleting, inserting, selection and style.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Mariusz Grzegorczyk]

Add missing expectations in editing subcategories: deleting, inserting, selection and style.

[Mariusz Grzegorczyk]

Created attachment 170169 [details]
patch

[Raphael Kubo da Costa (:rakuco)]

Do you know what's needed for the remaining editing tests in that big list to be unskipped?

[Gyuyoung Kim]

Comment on attachment 170169 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170169&action=review

> LayoutTests/ChangeLog:3


I think this patch is close to rebaseline or add new test case. Please add meaningful bug title. And, "Unreviewed" keyword is used in Reviewer name field, not bug title.

[Mariusz Grzegorczyk]

(In reply to comment #2)
> Do you know what's needed for the remaining editing tests in that big list to be unskipped?

My plan was to split gardening into 2 steps: first - big gardening with non problematic tests(current patch), second - describe and supply baselines for other tests(will need more investigation)

[Mariusz Grzegorczyk]

Created attachment 170341 [details]
Applied GyuYoung's comments

[WebKit Review Bot]

Comment on attachment 170341 [details]
Applied GyuYoung's comments

Rejecting attachment 170341 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
mand(args, input=patch.contents(), cwd=self._scm.checkout_root)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 406, in run_command
    output = process.communicate(string_to_communicate)[0]
  File "/usr/lib/python2.6/subprocess.py", line 701, in communicate
    return self._communicate(input)
  File "/usr/lib/python2.6/subprocess.py", line 1210, in _communicate
    bytes_written = os.write(self.stdin.fileno(), chunk)
OSError: [Errno 32] Broken pipe

Full output: http://queues.webkit.org/results/14554561

[Mariusz Grzegorczyk]

Created attachment 170577 [details]
patch with --binary option

[Ryuan Choi]

Comment on attachment 170577 [details]
patch with --binary option

OK, try once more.

[WebKit Review Bot]

Comment on attachment 170577 [details]
patch with --binary option

Rejecting attachment 170577 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ternals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 12787.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
LayoutTests/platform/efl-wk1/TestExpectations:317:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 2 files

Full output: http://queues.webkit.org/results/14555549

[WebKit Review Bot]

Comment on attachment 170577 [details]
patch with --binary option

Rejecting attachment 170577 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 12787.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 2 files

Full output: http://queues.webkit.org/results/14546658

[WebKit Review Bot]

Comment on attachment 170577 [details]
patch with --binary option

Rejecting attachment 170577 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 CHROMIUM: Add a method to WebLayerTreeView API

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14569709

[WebKit Review Bot]

Comment on attachment 170577 [details]
patch with --binary option

Clearing flags on attachment: 170577

Committed r132536: <http://trac.webkit.org/changeset/132536>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.