Bug 100119 – Web Inspector: [Styles] Handle non-parsedOk properties as inactive ones

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

This will help fix the display of matched and computed styles.

Patch to follow.

[Alexander Pavlov (apavlov)]

For this snippet:

body {
  text-align: left;
  text-align: bar;
  text-align: justify;
}

"text-align: bar" is non-parsedOk (has an exclamation mark) but does not have a strike-through.

Also, all of these properties will be shown as active in the computed trace, hence the user confusion.

[Alexander Pavlov (apavlov)]

Created attachment 170156 [details]
Patch

[Pavel Feldman]

Comment on attachment 170156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170156&action=review

> Source/WebCore/inspector/InspectorStyleSheet.cpp:533
> +                    CSSPropertyID propertyId = cssPropertyID(name);

We already have this code on the front-end, why having it here as well?

[Alexander Pavlov (apavlov)]

As agreed offline, this change will be coded in the front-end instead.

[Alexander Pavlov (apavlov)]

Created attachment 170354 [details]
Patch

[Alexander Pavlov (apavlov)]

Created attachment 170932 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 170932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170932&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1465
> +                    if (property.inactive || !property.parsedOk || section.isPropertyOverloaded(property.name))

I would add not-parsed-ok class to the rule that is setting line-through decoration instead.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1955
> +        if (this.property.inactive || !this.parsedOk)

ditto

[Alexander Pavlov (apavlov)]

Created attachment 171170 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 171170 [details]
Patch for landing

Clearing flags on attachment: 171170

Committed r132768: <http://trac.webkit.org/changeset/132768>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.