RESOLVED FIXED 100110
[EFL][WK2] ecore_x should be initialised in WebProcess to avoid re-initialization by PlatformScreenEfl utilities and systemBeep() function 
https://bugs.webkit.org/show_bug.cgi?id=100110
Summary [EFL][WK2] ecore_x should be initialised in WebProcess to avoid re-initializa...
Alexander Shalamov
Reported 2012-10-23 05:06:08 PDT
Netscape Plugin and MediaQueries depend on ecore_x functionality, therefore, ecore_x should be initialized when process starts to avoid re-initialization.
Attachments
Patch 1 (5.06 KB, patch)
2012-10-23 05:44 PDT, Alexander Shalamov 		no flags
DetailsFormatted DiffDiff
Patch 2 (5.31 KB, patch)
2012-10-23 05:55 PDT, Alexander Shalamov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexander Shalamov
Comment 1 2012-10-23 05:44:27 PDT
Created attachment 170134 [details] Patch 1 - initialize ecore_x in WebProcess - removed old workaround for ecore_x_init
Chris Dumez
Comment 2 2012-10-23 05:48:27 PDT
Comment on attachment 170134 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=170134&action=review > Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:71 > + if (!ecore_x_init(0)) { Where do we shutdown those libs? > Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:75 > + ecore_shutdown(); Missing eina_shutdown()
Kenneth Rohde Christiansen
Comment 3 2012-10-23 05:53:32 PDT
Comment on attachment 170134 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=170134&action=review > Source/WebKit2/ChangeLog:9 > + PlatformScreenEfl functions and systemBeep() depend on ecore_x functionality, therefore, > + ecore_x should be initialized when web process starts to avoid re-initialization. Does using ecore_x buy os anything than using X directly? and potentially share code with chrome/linux
Alexander Shalamov
Comment 4 2012-10-23 05:55:19 PDT
Created attachment 170137 [details] Patch 2 - Applied fixes according to review comments
Kenneth Rohde Christiansen
Comment 5 2012-10-23 05:58:25 PDT
Comment on attachment 170137 [details] Patch 2 r=me though I would rather share the Chrome WebScreenInfo code than use ecore_x
Alexander Shalamov
Comment 6 2012-10-23 06:01:21 PDT
(In reply to comment #3) > (From update of attachment 170134 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170134&action=review > > > Source/WebKit2/ChangeLog:9 > > + PlatformScreenEfl functions and systemBeep() depend on ecore_x functionality, therefore, > > + ecore_x should be initialized when web process starts to avoid re-initialization. > > Does using ecore_x buy os anything than using X directly? and potentially share code with chrome/linux That might be good idea to add shared code for the ports that use X. I think we need to discuss about that on mailing list and ask opinion from chromium folks.
WebKit Review Bot
Comment 7 2012-10-23 06:20:15 PDT
Comment on attachment 170137 [details] Patch 2 Clearing flags on attachment: 170137 Committed r132212: <http://trac.webkit.org/changeset/132212>
WebKit Review Bot
Comment 8 2012-10-23 06:20:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.