WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
Bug 100107
[CSS Shaders] Remove m_contextSize from the CustomFilterRenderer.
https://bugs.webkit.org/show_bug.cgi?id=100107
Summary
[CSS Shaders] Remove m_contextSize from the CustomFilterRenderer.
Dongseong Hwang
Reported
2012-10-23 04:11:40 PDT
We would need something like CustomFilterRendererState that will contain the size and other parameters in the future. We should pass that to bindProgramBuffers instead of storing it. There are two reasons. 1. Increase readability as separating changeable values from fixed values including shader program. 2. Be easy to reuse CustomFilterRenderer as making progress css shaders animation.
Attachments
Add attachment
proposed patch, testcase, etc.
Ralph T
Comment 1
2013-08-02 09:29:26 PDT
In my port, I'm now (sometimes) passing in a custom projection matrix so that I can avoid rendering to a texture and blending that to the framebuffer (which is needlessly wasteful of bandwidth and is too slow on some machines I target). Is your idea that we could also avoid rebinding the attributes and setting uniforms that have not changed since the last render?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug