Bug 100107 - [CSS Shaders] Remove m_contextSize from the CustomFilterRenderer.
Summary: [CSS Shaders] Remove m_contextSize from the CustomFilterRenderer.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 98989
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-23 04:11 PDT by Dongseong Hwang
Modified: 2014-03-02 09:35 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-10-23 04:11:40 PDT
We would need something like CustomFilterRendererState that will contain the size and other parameters in the future. We should pass that to bindProgramBuffers instead of storing it.

There are two reasons.
1. Increase readability as separating changeable values from fixed values including shader program.
2. Be easy to reuse CustomFilterRenderer as making progress css shaders animation.
Comment 1 Ralph T 2013-08-02 09:29:26 PDT
In my port, I'm now (sometimes) passing in a custom projection matrix so that I can avoid rendering to a texture and blending that to the framebuffer (which is needlessly wasteful of bandwidth and is too slow on some machines I target).

Is your idea that we could also avoid rebinding the attributes and setting uniforms that have not changed since the last render?