Bug 100105 - Web Inspector: Floated anchor element sometimes overlaps following content.
Summary: Web Inspector: Floated anchor element sometimes overlaps following content.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Trivial
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks: 97978
  Show dependency tree / graph
 
Reported: 2012-10-23 04:02 PDT by Mike West
Modified: 2012-11-01 07:09 PDT (History)
10 users (show)

See Also:

Attachments
Example of the bug on Ars Technica. (47.08 KB, image/png)
2012-10-23 04:06 PDT, Mike West 		no flags Details
Post-patch. (64.67 KB, image/png)
2012-10-23 04:42 PDT, Mike West 		no flags Details
Patch (1.93 KB, patch)
2012-10-23 04:45 PDT, Mike West 		no flags Details | Formatted Diff | Diff
Fixing top border. (2.19 KB, patch)
2012-10-23 04:59 PDT, Mike West 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2012-10-23 04:02:25 PDT 
Console messages' anchor element is floated right, which means that it sometimes overlaps following messages.
Comment 1 Mike West 2012-10-23 04:06:14 PDT 
Created attachment 170113 [details]
Example of the bug on Ars Technica.
Comment 2 Mike West 2012-10-23 04:42:06 PDT 
Created attachment 170121 [details]
Post-patch.
Comment 3 Mike West 2012-10-23 04:45:08 PDT 
Created attachment 170123 [details]
Patch
Comment 4 Alexander Pavlov (apavlov) 2012-10-23 04:51:18 PDT 
Comment on attachment 170123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170123&action=review

> Source/WebCore/inspector/front-end/inspector.css:890
> +    border-top: 1px solid rgb(240, 240, 240);

Does this cause an unwanted top border for the first message?
Comment 5 Mike West 2012-10-23 04:56:21 PDT 
(In reply to comment #4)
> (From update of attachment 170123 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170123&action=review
> 
> > Source/WebCore/inspector/front-end/inspector.css:890
> > +    border-top: 1px solid rgb(240, 240, 240);
> 
> Does this cause an unwanted top border for the first message?

Yes, it does. Crap. I'll spin a new patch in a moment.
Comment 6 Mike West 2012-10-23 04:59:31 PDT 
Created attachment 170126 [details]
Fixing top border.
Comment 7 Mike West 2012-10-23 05:01:03 PDT 
(In reply to comment #6)
> Created an attachment (id=170126) [details]
> Fixing top border.

This patch sets `border-top` to `none` for `.console-message:first-child`.
Comment 8 WebKit Review Bot 2012-10-23 09:07:50 PDT 
Comment on attachment 170126 [details]
Fixing top border.

Clearing flags on attachment: 170126

Committed r132230: <http://trac.webkit.org/changeset/132230>
Comment 9 WebKit Review Bot 2012-10-23 09:07:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Nikita Vasilyev 2012-11-01 07:09:09 PDT 
.console-message {overflow: hidden} seems to be the simpler solution.