Bug 100102 – [WK2] [GTK] TestWebKitAccessibility is not being run

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mario Sanchez Prada]

It seems a line got in run-gtk-tests by mistake along with SVN r120944, causing this test not to be run in WK2 bots:

     def _start_accessibility_daemons(self):
         return False
         spi_bus_launcher_path = self._lookup_atspi2_binary('at-spi-bus-launcher')
         spi_registryd_path = self._lookup_atspi2_binary('at-spi2-registryd')
         [...]

Additionally, there seems to be a mistake in configure.ac as well, since the following block is now _after_ the definition of enable_webkit2, meaning that the PKG_CHECK_MODULES is never executed:

  # check if atspi2 is available (only needed for Webkit2 unit tests)
  if test "$enable_webkit2" = "yes"; then
     PKG_CHECK_MODULES([ATSPI2],
                       [atspi-2 >= $ATSPI2_REQUIRED_VERSION],
                       [have_atspi2=yes], [have_atspi2=no])

     AC_SUBST([ATSPI2_CFLAGS])
     AC_SUBST([ATSPI2_LIBS])
  fi

This needs to be fixed

[Mario Sanchez Prada]

Created attachment 170110 [details]
Patch proposal

[Carlos Garcia Campos]

Comment on attachment 170110 [details]
Patch proposal

Thanks!

[Mario Sanchez Prada]

Committed r132328: <http://trac.webkit.org/changeset/132328>