Bug 100095 - Web Inspector: Console message's anchor element should be trimmed for readability.
Summary: Web Inspector: Console message's anchor element should be trimmed for readabi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks: 97978
  Show dependency treegraph
 
Reported: 2012-10-23 02:28 PDT by Mike West
Modified: 2012-11-28 23:28 PST (History)
10 users (show)

See Also:


Attachments
Image of looooong anchor elements. (65.21 KB, image/png)
2012-10-23 02:29 PDT, Mike West
no flags Details
Before the patch. (32.67 KB, image/png)
2012-11-26 05:47 PST, Mike West
no flags Details
After the patch. (23.30 KB, image/png)
2012-11-26 05:47 PST, Mike West
no flags Details
Patch (8.92 KB, patch)
2012-11-26 05:48 PST, Mike West
no flags Details | Formatted Diff | Diff
Fixing V8 expectation. (9.39 KB, patch)
2012-11-26 06:43 PST, Mike West
no flags Details | Formatted Diff | Diff
Patch (9.42 KB, patch)
2012-11-27 01:58 PST, Mike West
no flags Details | Formatted Diff | Diff
Patch (8.83 KB, patch)
2012-11-28 10:04 PST, Mike West
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2012-10-23 02:28:27 PDT
Looooong URLs used as the anchor for console messages (e.g. a call stack link) can overflow the width of the window. They should be trimmed.

Attached is an example of the issue.
Comment 1 Mike West 2012-10-23 02:29:53 PDT
Created attachment 170091 [details]
Image of looooong anchor elements.
Comment 2 Mike West 2012-11-26 05:47:12 PST
Created attachment 175976 [details]
Before the patch.
Comment 3 Mike West 2012-11-26 05:47:27 PST
Created attachment 175977 [details]
After the patch.
Comment 4 Mike West 2012-11-26 05:48:03 PST
Created attachment 175978 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-26 06:25:42 PST
Comment on attachment 175978 [details]
Patch

Attachment 175978 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14983666

New failing tests:
http/tests/inspector/network/script-as-text-loading-long-url.html
fast/text/atsui-small-caps-punctuation-size.html
Comment 6 Mike West 2012-11-26 06:43:59 PST
Created attachment 175997 [details]
Fixing V8 expectation.
Comment 7 Mike West 2012-11-26 06:47:25 PST
(In reply to comment #5)
> (From update of attachment 175978 [details])
> Attachment 175978 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/14983666
> 
> New failing tests:
> http/tests/inspector/network/script-as-text-loading-long-url.html
> fast/text/atsui-small-caps-punctuation-size.html

1. I commented out the critical bit of code to generate the "before" screenshot. I left it in when I uploaded the patch. I am an idiot. :)
2. I needed to have a platform-specific result here, so it wouldn't have worked anyway.

Latest patch should fix the issues.
Comment 8 Build Bot 2012-11-26 17:47:09 PST
Comment on attachment 175997 [details]
Fixing V8 expectation.

Attachment 175997 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14984870

New failing tests:
http/tests/inspector/network/script-as-text-loading-long-url.html
Comment 9 Mike West 2012-11-27 01:58:56 PST
Created attachment 176202 [details]
Patch
Comment 10 Mike West 2012-11-28 01:46:42 PST
(In reply to comment #9)
> Created an attachment (id=176202) [details]
> Patch

Friendly ping. Any inspector folks interested in picking this up? :)
Comment 11 Pavel Feldman 2012-11-28 07:06:13 PST
Comment on attachment 176202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176202&action=review

Please fix the nit prior to landing.

> Source/WebCore/inspector/front-end/inspector.js:997
> +WebInspector.MaxLengthForDisplayedURLs = 150;

inspectot.js is currently not compiled - it depends from the universe. We should declare constants in common places instead. Such as WebInspector.Linkifier.MaxLengthForDisplayedURLs
Comment 12 Mike West 2012-11-28 10:04:01 PST
Created attachment 176508 [details]
Patch
Comment 13 WebKit Review Bot 2012-11-28 23:28:51 PST
Comment on attachment 176508 [details]
Patch

Clearing flags on attachment: 176508

Committed r136104: <http://trac.webkit.org/changeset/136104>
Comment 14 WebKit Review Bot 2012-11-28 23:28:55 PST
All reviewed patches have been landed.  Closing bug.