RESOLVED FIXED100091
Memory instrumentation: add reportMemoryUsage to ImageObserver interface 
https://bugs.webkit.org/show_bug.cgi?id=100091
Summary Memory instrumentation: add reportMemoryUsage to ImageObserver interface
Yury Semikhatsky
Reported 2012-10-23 01:42:04 PDT
CachedImage is derived from both CachedResource and ImageObserver. When CachedImage is reported as ImageObserver* it is treated as standalone object and will be counted second time as CacnedImage. To avoid this we need to make sure ImageObserver has virtual method for reporting adjusted pointer.
Attachments
Patch (5.87 KB, patch)
2012-10-25 07:45 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-10-25 07:45:50 PDT
Created attachment 170649 [details] Patch
Yury Semikhatsky
Comment 2 2012-10-25 07:50:18 PDT
Comment on attachment 170649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170649&action=review > Source/WebKit/chromium/WebKit.gypi:89 > + 'tests/MemoryInstrumentationTest.cpp', I tried to add the test to Tools/TestWebKitAPI/Tests/WebCore/MemoryInstrumentation.cpp but gave up as it was failing in some very weird places during ResourceRequest construction. It looks like we have to add some dependencies to the corresponding build target(so that WebCore is properly initialized) but I failed to figure out which one and put the test under WebKit/chromium/tests for now.
Ilya Tikhonovsky
Comment 3 2012-10-25 07:52:14 PDT
Comment on attachment 170649 [details] Patch lgtm
WebKit Review Bot
Comment 4 2012-10-25 08:29:12 PDT
Comment on attachment 170649 [details] Patch Clearing flags on attachment: 170649 Committed r132486: <http://trac.webkit.org/changeset/132486>
WebKit Review Bot
Comment 5 2012-10-25 08:29:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.