Bug 100090 - Web Inspector: Fix "check-inspector-strings" script and fix localized strings.
Summary: Web Inspector: Fix "check-inspector-strings" script and fix localized strings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: eustas.bug
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-23 01:34 PDT by eustas.bug
Modified: 2012-10-25 00:32 PDT (History)
14 users (show)

See Also:

Attachments
Patch (27.95 KB, patch)
2012-10-23 01:59 PDT, eustas.bug 		no flags Details | Formatted Diff | Diff
Patch (27.96 KB, patch)
2012-10-23 02:46 PDT, eustas.bug 		no flags Details | Formatted Diff | Diff
Patch (27.26 KB, patch)
2012-10-23 04:55 PDT, eustas.bug 		no flags Details | Formatted Diff | Diff
Patch (11.74 KB, patch)
2012-10-24 02:15 PDT, eustas.bug 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description eustas.bug 2012-10-23 01:34:50 PDT 
Script "check-inspector-strings" seems to be broken.
Fixed it, refined search algorithm, introduced "/* LOCALIZED */" marker.
Comment 1 eustas.bug 2012-10-23 01:59:32 PDT 
Created attachment 170085 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-23 02:02:55 PDT 
Attachment 170085 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 eustas.bug 2012-10-23 02:46:41 PDT 
Created attachment 170099 [details]
Patch

fixed-cl-entry
Comment 4 eustas.bug 2012-10-23 04:55:37 PDT 
Created attachment 170125 [details]
Patch

rebased
Comment 5 Vsevolod Vlasov 2012-10-23 09:18:43 PDT 
I would not land this LOCALIZED comments part.
I don't think they introduce any clear immediate value while making the code look UGLY.
Comment 6 eustas.bug 2012-10-24 02:15:03 PDT 
Created attachment 170345 [details]
Patch
Comment 7 WebKit Review Bot 2012-10-25 00:32:49 PDT 
Comment on attachment 170345 [details]
Patch

Clearing flags on attachment: 170345

Committed r132455: <http://trac.webkit.org/changeset/132455>
Comment 8 WebKit Review Bot 2012-10-25 00:32:53 PDT 
All reviewed patches have been landed.  Closing bug.