Bug 10009 - REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)
Summary: REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2006-07-19 09:07 PDT by Doug
Modified: 2006-07-24 08:55 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (3.37 KB, patch)
2006-07-23 13:10 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Doug 2006-07-19 09:07:23 PDT 
The PDF plug-in works in regular Safari, but in the nightly builds (at least the last few that I've used), PDFs don't appear (just a missing graphic "X"). I'm not sure if the problem lies with WebKit or the plug-in itself, but I thought I should report it.
Comment 1 Alexey Proskuryakov 2006-07-19 21:59:50 PDT 
Notably, the plugin works for OBJECTs embedded in HTML (see the second example at <http://acroeng.adobe.com/bugzilla/pdfbug.html>, but not for plain PDF files. This might turn out to be a WebKit issue indeed.
Comment 2 Alexey Proskuryakov 2006-07-23 13:10:10 PDT 
Created attachment 9636 [details]
proposed fix

Couldn't find a way to make a layout test, suggestions are welcome!
Comment 3 Darin Adler 2006-07-23 13:39:56 PDT 
Comment on attachment 9636 [details]
proposed fix

Why is this PDF-specific? What if our image support extends to embrace something that a plug-in wants to handle better?
Comment 4 Alexey Proskuryakov 2006-07-23 13:43:21 PDT 
(In reply to comment #3)
> Why is this PDF-specific? 

I wanted to prevent QuickTime from taking over all images.
Comment 5 Darin Adler 2006-07-24 08:30:11 PDT 
Comment on attachment 9636 [details]
proposed fix

Looks OK for now. Would be better to have a comment since this logic is subtle.
Comment 6 Alexey Proskuryakov 2006-07-24 08:55:59 PDT 
Committed revision 15598.

(In reply to comment #5)
> Would be better to have a comment since this logic is subtle.

I absolutely agree, and have tried to come up with one, but couldn't produce anything concise :-/