Bug 100047 - Clear m_mediaSource reference when the MediaSource is closed
Summary: Clear m_mediaSource reference when the MediaSource is closed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aaron Colwell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-22 16:22 PDT by Aaron Colwell
Modified: 2012-10-23 16:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2012-10-22 16:35 PDT, Aaron Colwell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Colwell 2012-10-22 16:22:20 PDT
The existing code in HTMLMediaElement holds the reference to m_mediaSource longer then it needs to. The object shouldn't be used again after it has transitioned to "closed" so I'm adding code to clear the reference when this transition happens.
Comment 1 Aaron Colwell 2012-10-22 16:35:11 PDT
Created attachment 170019 [details]
Patch
Comment 2 Early Warning System Bot 2012-10-22 16:54:44 PDT
Comment on attachment 170019 [details]
Patch

Attachment 170019 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14489715
Comment 3 Darin Adler 2012-10-22 18:23:29 PDT
Comment on attachment 170019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170019&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests because the change isn't visible to JavaScript.

Understood that it is not “visible to JavaScript”. What end user detectable effect does it have?
Comment 4 Aaron Colwell 2012-10-23 07:26:06 PDT
(In reply to comment #3)
> (From update of attachment 170019 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170019&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        No new tests because the change isn't visible to JavaScript.
> 
> Understood that it is not “visible to JavaScript”. What end user detectable effect does it have?

I don't believe it has an end user detectable effect. This change simply makes the object state more consistent so code can't access the object when it isn't supposed to.
Comment 5 Aaron Colwell 2012-10-23 07:30:12 PDT
Comment on attachment 170019 [details]
Patch

resetting commit-queue? since the qt-wk2 failure doesn't appear to be related to my change.
Comment 6 WebKit Review Bot 2012-10-23 16:15:32 PDT
Comment on attachment 170019 [details]
Patch

Clearing flags on attachment: 170019

Committed r132280: <http://trac.webkit.org/changeset/132280>
Comment 7 WebKit Review Bot 2012-10-23 16:15:35 PDT
All reviewed patches have been landed.  Closing bug.