Bug 100043 - Don't include individual strategy headers
Summary: Don't include individual strategy headers
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on: 100031
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-22 15:56 PDT by Alexey Proskuryakov
Modified: 2012-10-22 16:58 PDT (History)
16 users (show)

See Also:

Attachments
proposed patch (5.90 KB, patch)
2012-10-22 15:59 PDT, Alexey Proskuryakov 		beidson: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-10-22 15:56:47 PDT 
Now that PlatformStrategies.h has them all.
Comment 1 Alexey Proskuryakov 2012-10-22 15:59:08 PDT 
Created attachment 170010 [details]
proposed patch

EWS will bark, because this depends on bug 100031.
Comment 2 Early Warning System Bot 2012-10-22 16:02:15 PDT 
Comment on attachment 170010 [details]
proposed patch

Attachment 170010 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14496431
Comment 3 Early Warning System Bot 2012-10-22 16:04:04 PDT 
Comment on attachment 170010 [details]
proposed patch

Attachment 170010 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14481732
Comment 4 Brady Eidson 2012-10-22 16:15:00 PDT 
Comment on attachment 170010 [details]
proposed patch

I understand this patch relies on 100031 and that's why EWSs are failing.  It seems straightforward enough to r+ anyways, trusting that you'll watch things when you land.
Comment 5 Build Bot 2012-10-22 16:16:37 PDT 
Comment on attachment 170010 [details]
proposed patch

Attachment 170010 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14488605
Comment 6 EFL EWS Bot 2012-10-22 16:24:21 PDT 
Comment on attachment 170010 [details]
proposed patch

Attachment 170010 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14499355
Comment 7 Build Bot 2012-10-22 16:25:04 PDT 
Comment on attachment 170010 [details]
proposed patch

Attachment 170010 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14483695
Comment 8 Alexey Proskuryakov 2012-10-22 16:58:26 PDT 
Depends on a flawed refactoring.