WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
100032
[chromium] handle new 10.8 baselines, sort of
https://bugs.webkit.org/show_bug.cgi?id=100032
Summary
[chromium] handle new 10.8 baselines, sort of
Dirk Pranke
Reported
2012-10-22 14:24:48 PDT
[chromium] handle new 10.8 baselines, sort of
Attachments
Patch
(2.13 KB, patch)
2012-10-22 14:26 PDT
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2012-10-22 14:26:21 PDT
Created
attachment 169985
[details]
Patch
Dirk Pranke
Comment 2
2012-10-22 14:30:26 PDT
This patch is a double-edged sword. If Mountain Lion is failing a test and the baseline in platform/chromium-mac needs to be updated, and the existing platform/chromium-mac baseline is correct for Lion, then this will do the right thing. If it isn't (i.e., the test will fail on both, but the Lion bot hasn't cycled yet and started failing), then it will do the wrong thing, because it'll copy the old/bad baseline into platform/chromium-mac-lion and cause that bot to fail on the next run. (However, if we pull the baseline for the ML bot before the Lion bot, then (I think?) the Lion bot will then re-overwrite the chromium-mac-lion baseline and self-correct. I need to step through this to make sure. Until I am, we probably don't want to land this patch, but it's okay to use if you know what you're doing and/or review the changes carefully.
Emil A Eklund
Comment 3
2012-10-22 14:50:14 PDT
So if I run this once all bots have cycled it should do the right thing, right?
Dirk Pranke
Comment 4
2012-10-22 14:56:12 PDT
Correct.
Dirk Pranke
Comment 5
2012-11-02 15:15:34 PDT
this has been obsoleted by the --move-overwritten-baselines approach now in garden-o-matic.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug