Bug 100027 – [chromium] Remove unused GraphicsContext3DPrivate memory management

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Christopher Cameron]

[chromium] Remove unused GraphicsContext3DPrivate memory management

[Christopher Cameron]

Created attachment 169979 [details]
Patch

[Christopher Cameron]

Simple change, removing dead code.

[James Robinson]

Comment on attachment 169979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169979&action=review

> Source/WebCore/platform/chromium/support/GraphicsContext3DPrivate.cpp:-110
> -            m_context->setTextureCacheLimits(maxGaneshTextureCacheCount, maxGaneshTextureCacheBytes);

This appears to actually do something, at least in theory.  Do we never use this callback for canvas today?  Do you have a replacement in mind for managing ganesh' texture use?

[Christopher Cameron]

Comment on attachment 169979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169979&action=review

>> Source/WebCore/platform/chromium/support/GraphicsContext3DPrivate.cpp:-110
>> -            m_context->setTextureCacheLimits(maxGaneshTextureCacheCount, maxGaneshTextureCacheBytes);
> 
> This appears to actually do something, at least in theory.  Do we never use this callback for canvas today?  Do you have a replacement in mind for managing ganesh' texture use?

I ran a bunch more experiments, and did manage to get this to do something -- a canvas can manage to get a hint to drop textures if it is in a share group with a renderer that is not "hibernated" (not visible for a long time).  I guess it's safe to leave this for now.  It would be preferable for this to get visibility information directly, and act on that, rather than going through this roundabout path.

[James Robinson]

The ganesh-owned context is used for things like canvas and filters, which aren't uniquely associated with any given tabs and thus don't really have clear notions of visibility.  Anyway, looks like this code can't be killed just yet.

[Christopher Cameron]

(In reply to comment #5)
> The ganesh-owned context is used for things like canvas and filters, which aren't uniquely associated with any given tabs and thus don't really have clear notions of visibility.  Anyway, looks like this code can't be killed just yet.

Yeah, I'll keep my finger off of the trigger for now.