Bug 100024 - Add a microbenchmark for Hindi (complex-text) line-layout
Summary: Add a microbenchmark for Hindi (complex-text) line-layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 100036 99393
  Show dependency treegraph
 
Reported: 2012-10-22 13:52 PDT by Eric Seidel (no email)
Modified: 2012-10-26 18:37 PDT (History)
5 users (show)

See Also:


Attachments
Patch (15.59 KB, patch)
2012-10-22 13:54 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
the JS API changed out from under me (15.60 KB, patch)
2012-10-22 16:16 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-10-22 13:52:45 PDT
Add a microbenchmark for Hindi (complex-text) line-layout
Comment 1 Eric Seidel (no email) 2012-10-22 13:54:17 PDT
Created attachment 169975 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-22 14:15:24 PDT
I'm going to re-verify the slowdown with r131528 and then I'll file a regression bug if it's still slower than Safari 6.0.1.
Comment 3 Eric Seidel (no email) 2012-10-22 14:51:28 PDT
I wrote this microbenchmark to make sure that bug 99393 wouldn't be a slowdown for complex text for Harfbuzz ports.
Comment 4 Eric Seidel (no email) 2012-10-22 15:38:42 PDT
(In reply to comment #2)
> I'm going to re-verify the slowdown with r131528 and then I'll file a regression bug if it's still slower than Safari 6.0.1.

Filed as bug 100036.
Comment 5 Eric Seidel (no email) 2012-10-22 16:16:42 PDT
Created attachment 170015 [details]
the JS API changed out from under me
Comment 6 Eric Seidel (no email) 2012-10-26 18:16:09 PDT
Ping reviewers?
Comment 7 Ryosuke Niwa 2012-10-26 18:19:29 PDT
Comment on attachment 170015 [details]
the JS API changed out from under me

View in context: https://bugs.webkit.org/attachment.cgi?id=170015&action=review

> PerformanceTests/Layout/hindi-line-layout.html:36
> +        function test() {
> +            style.display = "block";
> +            style.width = "280px";
> +            target.offsetLeft;
> +            style.width = "300px";
> +            target.offsetLeft;
> +            style.width = "290px";
> +            target.offsetLeft;
> +            style.display = "none";
> +        }

You can use anonymous function in the call to measureRunsPerSecond instead of defining a function since it’s not used elsewhere.
Comment 8 Eric Seidel (no email) 2012-10-26 18:30:06 PDT
Comment on attachment 170015 [details]
the JS API changed out from under me

View in context: https://bugs.webkit.org/attachment.cgi?id=170015&action=review

>> PerformanceTests/Layout/hindi-line-layout.html:36
>> +        }
> 
> You can use anonymous function in the call to measureRunsPerSecond instead of defining a function since it’s not used elsewhere.

Thanks.  This is just a copy of line-layout.html.  If you'd like I can make a follow-up change to fix them both?
Comment 9 WebKit Review Bot 2012-10-26 18:37:37 PDT
Comment on attachment 170015 [details]
the JS API changed out from under me

Clearing flags on attachment: 170015

Committed r132717: <http://trac.webkit.org/changeset/132717>
Comment 10 WebKit Review Bot 2012-10-26 18:37:41 PDT
All reviewed patches have been landed.  Closing bug.