Bug 100024 – Add a microbenchmark for Hindi (complex-text) line-layout

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Add a microbenchmark for Hindi (complex-text) line-layout

[Eric Seidel (no email)]

Created attachment 169975 [details]
Patch

[Eric Seidel (no email)]

I'm going to re-verify the slowdown with r131528 and then I'll file a regression bug if it's still slower than Safari 6.0.1.

[Eric Seidel (no email)]

I wrote this microbenchmark to make sure that bug 99393 wouldn't be a slowdown for complex text for Harfbuzz ports.

[Eric Seidel (no email)]

(In reply to comment #2)
> I'm going to re-verify the slowdown with r131528 and then I'll file a regression bug if it's still slower than Safari 6.0.1.

Filed as bug 100036.

[Eric Seidel (no email)]

Created attachment 170015 [details]
the JS API changed out from under me

[Eric Seidel (no email)]

Ping reviewers?

[Ryosuke Niwa]

Comment on attachment 170015 [details]
the JS API changed out from under me

View in context: https://bugs.webkit.org/attachment.cgi?id=170015&action=review

> PerformanceTests/Layout/hindi-line-layout.html:36
> +        function test() {
> +            style.display = "block";
> +            style.width = "280px";
> +            target.offsetLeft;
> +            style.width = "300px";
> +            target.offsetLeft;
> +            style.width = "290px";
> +            target.offsetLeft;
> +            style.display = "none";
> +        }

You can use anonymous function in the call to measureRunsPerSecond instead of defining a function since it’s not used elsewhere.

[Eric Seidel (no email)]

Comment on attachment 170015 [details]
the JS API changed out from under me

View in context: https://bugs.webkit.org/attachment.cgi?id=170015&action=review

>> PerformanceTests/Layout/hindi-line-layout.html:36
>> +        }
> 
> You can use anonymous function in the call to measureRunsPerSecond instead of defining a function since it’s not used elsewhere.

Thanks.  This is just a copy of line-layout.html.  If you'd like I can make a follow-up change to fix them both?

[WebKit Review Bot]

Comment on attachment 170015 [details]
the JS API changed out from under me

Clearing flags on attachment: 170015

Committed r132717: <http://trac.webkit.org/changeset/132717>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.