RESOLVED FIXED100022
More Argument coder cleanup 
https://bugs.webkit.org/show_bug.cgi?id=100022
Summary More Argument coder cleanup
Anders Carlsson
Reported 2012-10-22 13:42:14 PDT
More Argument coder cleanup
Attachments
Patch (32.16 KB, patch)
2012-10-22 13:48 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (33.85 KB, patch)
2012-10-22 14:11 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (33.85 KB, patch)
2012-10-22 15:05 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (34.81 KB, patch)
2012-10-22 15:16 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (34.81 KB, patch)
2012-10-22 15:36 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (38.24 KB, patch)
2012-10-22 16:22 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-22 13:48:52 PDT
Created attachment 169973 [details] Patch
WebKit Review Bot
Comment 2 2012-10-22 13:54:37 PDT
Attachment 169973 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:196: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2012-10-22 13:56:52 PDT
Comment on attachment 169973 [details] Patch Attachment 169973 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14486631
Anders Carlsson
Comment 4 2012-10-22 14:11:17 PDT
Created attachment 169982 [details] Patch
WebKit Review Bot
Comment 5 2012-10-22 14:15:24 PDT
Attachment 169982 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:196: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 6 2012-10-22 14:31:31 PDT
Comment on attachment 169982 [details] Patch Attachment 169982 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14488568
Anders Carlsson
Comment 7 2012-10-22 15:05:46 PDT
Created attachment 169996 [details] Patch
WebKit Review Bot
Comment 8 2012-10-22 15:07:23 PDT
Attachment 169996 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:196: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 9 2012-10-22 15:13:54 PDT
Comment on attachment 169996 [details] Patch Attachment 169996 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14488580
Anders Carlsson
Comment 10 2012-10-22 15:16:03 PDT
Created attachment 169999 [details] Patch
WebKit Review Bot
Comment 11 2012-10-22 15:19:06 PDT
Attachment 169999 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:190: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 12 2012-10-22 15:27:38 PDT
Comment on attachment 169999 [details] Patch Attachment 169999 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14489673
Anders Carlsson
Comment 13 2012-10-22 15:36:13 PDT
Created attachment 170001 [details] Patch
WebKit Review Bot
Comment 14 2012-10-22 15:37:32 PDT
Attachment 170001 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:190: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 15 2012-10-22 16:14:35 PDT
Comment on attachment 170001 [details] Patch Attachment 170001 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14505198
Anders Carlsson
Comment 16 2012-10-22 16:22:39 PDT
Created attachment 170017 [details] Patch
WebKit Review Bot
Comment 17 2012-10-22 16:25:34 PDT
Attachment 170017 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:190: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 18 2012-10-22 16:37:01 PDT
Comment on attachment 170017 [details] Patch r+ regards, kling
Anders Carlsson
Comment 19 2012-10-22 16:38:30 PDT
(In reply to comment #18) > (From update of attachment 170017 [details]) > r+ > regards, kling u r tru frand
Anders Carlsson
Comment 20 2012-10-22 16:51:30 PDT
Committed r132161: <http://trac.webkit.org/changeset/132161>
Note You need to log in before you can comment on or make changes to this bug.