Bug 100021 – Web Inspector: show internal properties in inspector frontend

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

Internal properties (such as [[PrimitiveValue]] or [[BoundFunction]]) are supported in protocol and backend.
Now they should become visible in frontend UI.

[Peter Rybin]

Created attachment 169977 [details]
Patch

[Vsevolod Vlasov]

Screenshot?

[Peter Rybin]

Created attachment 170135 [details]
UI preview

[Peter Rybin]

Created attachment 170146 [details]
Patch

[Peter Rybin]

Created attachment 170153 [details]
Patch

[Peter Rybin]

Created attachment 170154 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #3)
> Created an attachment (id=170135) [details]
> UI preview

We show uncaught exception object as a variable with name <exception>. Could you adhere to the same style for the internal properties you are adding?

[Yury Semikhatsky]

Comment on attachment 170154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170154&action=review

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:455
> +                treeElement.appendChild(new WebInspector.FunctionScopeMainTreeElement(value));

Please add a test for this.

[Peter Rybin]

(In reply to comment #7)
> (In reply to comment #3)
> > Created an attachment (id=170135) [details] [details]
> > UI preview
> 
> We show uncaught exception object as a variable with name <exception>. Could you adhere to the same style for the internal properties you are adding?

[Peter Rybin]

[I'm sorry for the empty comment above].

> > > UI preview
> > We show uncaught exception object as a variable with name <exception>. Could you adhere to the same style for the internal properties you are adding?

This patch doesn't make property names. They are defined in V8 according to their names in specification.

However we could manually restyle them in front-end using RegExp technique, but I'm not sure it's what you'd like to do.

[Peter Rybin]

Created attachment 173908 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 173908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173908&action=review

> LayoutTests/http/tests/inspector/elements-test.js:268
> +            return "'" + node.innerHTML + "'";

textContent

> LayoutTests/http/tests/inspector/elements-test.js:278
> +            dumpTreeElement(treeElement.children[i], prefix + "    ");

remove brackets for one line for block

[Peter Rybin]

Created attachment 173918 [details]
Patch

[Peter Rybin]

(In reply to comment #8)
> (From update of attachment 170154 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170154&action=review
> 
> > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:455
> > +                treeElement.appendChild(new WebInspector.FunctionScopeMainTreeElement(value));
> 
> Please add a test for this.

Done

[Peter Rybin]

> > LayoutTests/http/tests/inspector/elements-test.js:268
> > +            return "'" + node.innerHTML + "'";
> textContent

Done

> > LayoutTests/http/tests/inspector/elements-test.js:278
> > +            dumpTreeElement(treeElement.children[i], prefix + "    ");
> remove brackets for one line for block

Done

[Build Bot]

Comment on attachment 173918 [details]
Patch

Attachment 173918 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14832130

New failing tests:
inspector/debugger/properties-special.html

[Yury Semikhatsky]

Comment on attachment 173918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173918&action=review

> LayoutTests/inspector/debugger/properties-special.html:61
> +    function nodesExpanded() {

style nit: { should go on the next line.

[Peter Rybin]

Created attachment 174458 [details]
Patch

[Peter Rybin]

> > LayoutTests/inspector/debugger/properties-special.html:61
> > +    function nodesExpanded() {
> style nit: { should go on the next line.

Done

[WebKit Review Bot]

Comment on attachment 174458 [details]
Patch

Clearing flags on attachment: 174458

Committed r134914: <http://trac.webkit.org/changeset/134914>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.