WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100018
Remove unnecessary m_layoutDelta[XY]Saturated initialization
https://bugs.webkit.org/show_bug.cgi?id=100018
Summary
Remove unnecessary m_layoutDelta[XY]Saturated initialization
Emil A Eklund
Reported
2012-10-22 13:13:44 PDT
From comment on
bug 98692
:
> Source/WebCore/rendering/LayoutState.cpp:43 > +#if !ASSERT_DISABLED && ENABLE(SATURATED_LAYOUT_ARITHMETIC) > + , m_layoutDeltaXSaturated(false) > + , m_layoutDeltaYSaturated(false) > +#endif
Why initialize these here since they are unconditionally set in the function body below? This makes things more ugly for no real reason.
Attachments
Patch
(1.36 KB, patch)
2012-10-22 13:15 PDT
,
Emil A Eklund
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Emil A Eklund
Comment 1
2012-10-22 13:15:11 PDT
Created
attachment 169962
[details]
Patch
Julien Chaffraix
Comment 2
2012-10-22 19:00:57 PDT
Comment on
attachment 169962
[details]
Patch r=me, would have been nice to put a bit of context in the ChangeLog.
Emil A Eklund
Comment 3
2012-10-23 09:22:50 PDT
Committed
r132233
: <
http://trac.webkit.org/changeset/132233
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug