[chromium] Expose setInitialCssScale on the WebLayer API
Created attachment 169937 [details] Patch
This depends on https://codereview.chromium.org/11227031/ and blocks relanding https://codereview.chromium.org/10915313
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 169937 [details] Patch Attachment 169937 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14486577
Comment on attachment 169937 [details] Patch Attachment 169937 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14489580
Created attachment 169960 [details] Patch
updated to opt-in
Comment on attachment 169960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169960&action=review > Source/Platform/chromium/public/WebLayer.h:108 > + virtual void setAutomaticallyComputeRasterScale(bool) = 0; I feel like this is more of a WebContentLayer concern than a general WebLayer one.
Comment on attachment 169960 [details] Patch Attachment 169960 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14514001
Comment on attachment 169960 [details] Patch Attachment 169960 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14516001
Created attachment 169965 [details] Patch Moved to WebContentLayer
Comment on attachment 169965 [details] Patch Attachment 169965 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14487555
Comment on attachment 169965 [details] Patch Attachment 169965 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14496378
Comment on attachment 169965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169965&action=review > Source/Platform/chromium/public/WebContentLayer.h:54 > + virtual void setAutomaticallyComputeRasterScale(bool) = 0; If you provide a default implementation instead of having it be pure virtual here landing will be a lot easier. Please document the default (false, I presume)
Comment on attachment 169965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169965&action=review >> Source/Platform/chromium/public/WebContentLayer.h:54 >> + virtual void setAutomaticallyComputeRasterScale(bool) = 0; > > If you provide a default implementation instead of having it be pure virtual here landing will be a lot easier. > > Please document the default (false, I presume) Oh, sure. 2 patches instead of 1. Or will I need to come back here and remove the default implementation after? False, yep. k.
(In reply to comment #15) > (From update of attachment 169965 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169965&action=review > > >> Source/Platform/chromium/public/WebContentLayer.h:54 > >> + virtual void setAutomaticallyComputeRasterScale(bool) = 0; > > > > If you provide a default implementation instead of having it be pure virtual here landing will be a lot easier. > > > > Please document the default (false, I presume) > > Oh, sure. 2 patches instead of 1. Or will I need to come back here and remove the default implementation after? Wouldn't necessarily need to. It'd be good to be consistent, but might be better to just have all of these have default impls to make changing other APIs easier as well. Even if you did you wouldn't have to worry about synchronizing it with anything else.
Created attachment 170008 [details] Patch Default impl and document return value
Comment on attachment 170008 [details] Patch Clearing flags on attachment: 170008 Committed r132223: <http://trac.webkit.org/changeset/132223>
All reviewed patches have been landed. Closing bug.