Bug 99954

Summary: [V8] V8EnablePerContext shouldn't require document() accessor to the native object.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, haraken, japhet, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100097    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Hajime Morrita 2012-10-21 22:32:10 PDT 
This is demanded by Bug 99780.
Comment 1 Hajime Morrita 2012-10-21 22:35:48 PDT 
Created attachment 169830 [details]
Patch
Comment 2 Kentaro Hara 2012-10-21 23:36:13 PDT 
Comment on attachment 169830 [details]
Patch

Looks OK
Comment 3 WebKit Review Bot 2012-10-21 23:44:19 PDT 
Comment on attachment 169830 [details]
Patch

Clearing flags on attachment: 169830

Committed r132033: <http://trac.webkit.org/changeset/132033>
Comment 4 WebKit Review Bot 2012-10-21 23:44:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2012-10-23 02:43:12 PDT 
Re-opened since this is blocked by bug 100097
Comment 6 Kent Tamura 2012-10-23 02:50:03 PDT 
(In reply to comment #3)
> (From update of attachment 169830 [details])
> Clearing flags on attachment: 169830
> 
> Committed r132033: <http://trac.webkit.org/changeset/132033>

I rolled it out because it broke DOMWindow::pagePopupController.

void V8DOMWindow::installPerContextProperties(v8::Handle<v8::Object> instance, DOMWindow* impl)
{
    v8::Local<v8::Object> proto = v8::Local<v8::Object>::Cast(instance->GetPrototype());
    ScriptExecutionContext* context = toScriptExecutionContext(proto->CreationContext());

"context" was null.
Comment 7 Brian Burg 2014-12-16 00:48:24 PST 
Closing some V8-related work items.