Bug 99954 – [V8] V8EnablePerContext shouldn't require document() accessor to the native object.

• Component: DOM
• Status: RESOLVED INVALID

[Hajime Morrita]

This is demanded by Bug 99780.

[Hajime Morrita]

Created attachment 169830 [details]
Patch

[Kentaro Hara]

Comment on attachment 169830 [details]
Patch

Looks OK

[WebKit Review Bot]

Comment on attachment 169830 [details]
Patch

Clearing flags on attachment: 169830

Committed r132033: <http://trac.webkit.org/changeset/132033>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 100097

[Kent Tamura]

(In reply to comment #3)
> (From update of attachment 169830 [details])
> Clearing flags on attachment: 169830
> 
> Committed r132033: <http://trac.webkit.org/changeset/132033>

I rolled it out because it broke DOMWindow::pagePopupController.

void V8DOMWindow::installPerContextProperties(v8::Handle<v8::Object> instance, DOMWindow* impl)
{
    v8::Local<v8::Object> proto = v8::Local<v8::Object>::Cast(instance->GetPrototype());
    ScriptExecutionContext* context = toScriptExecutionContext(proto->CreationContext());

"context" was null.

[Brian Burg]

Closing some V8-related work items.