Bug 99946

Summary: Add int64 wrapper for WebKit2 API
Product: WebKit Reporter: Jiyeon Kim <jiyeon0402.kim>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: andersca, ap, gyuyoung.kim, jye.kang, kihong.kwon, sunaeluv.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97417    
Attachments:
Description Flags
Patch ap: review-

Jiyeon Kim
Reported 2012-10-21 17:29:48 PDT
Add int64 wrapper for WebKit2 API. Int64 value will be used to get/set application cache quota size.
Attachments
Patch (6.68 KB, patch)
2012-10-21 19:17 PDT, Jiyeon Kim 		ap: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiyeon Kim
Comment 1 2012-10-21 19:17:36 PDT
Created attachment 169822 [details] Patch
Alexey Proskuryakov
Comment 2 2012-10-22 11:39:13 PDT
Thank you for providing a rationale! Int64 can have negative values. Is that a good match for application cache quota?
Jiyeon Kim
Comment 3 2012-10-22 16:06:18 PDT
(In reply to comment #2) > Thank you for providing a rationale! > > Int64 can have negative values. Is that a good match for application cache quota? The return type of "defaultOriginQuota()" in ApplicationCacheStorage.h is "int64_t". Also "setDefaultOriginQuota()" argument is int64_t type. So I think It needs int64_t wrapper for supporting these APIs for webkit2.
Jiyeon Kim
Comment 4 2012-10-22 22:47:01 PDT
(In reply to comment #3) > (In reply to comment #2) > > Thank you for providing a rationale! > > > > Int64 can have negative values. Is that a good match for application cache quota? > The return type of "defaultOriginQuota()" in ApplicationCacheStorage.h is "int64_t". Also "setDefaultOriginQuota()" argument is int64_t type. So I think It needs int64_t wrapper for supporting these APIs for webkit2. But I also think that quota doesn't need to be negative value.
Jiyeon Kim
Comment 5 2012-10-30 02:36:11 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Thank you for providing a rationale! > > > > > > Int64 can have negative values. Is that a good match for application cache quota? > > The return type of "defaultOriginQuota()" in ApplicationCacheStorage.h is "int64_t". Also "setDefaultOriginQuota()" argument is int64_t type. So I think It needs int64_t wrapper for supporting these APIs for webkit2. > But I also think that quota doesn't need to be negative value. I also have a plan to make some apis for getting disk usage of local storage and application cache. These apis will use StorageTracker::diskUsageForOrigin and ApplicationCache::diskUsageForOrigin return long long type. So I think we need int64 wrapper for WebKit2. Please review this patch.
Alexey Proskuryakov
Comment 6 2012-10-30 08:39:06 PDT
Comment on attachment 169822 [details] Patch > I also have a plan to make some apis for getting disk usage of local storage and application cache. These also don't need to be signed. r-, since there is no compelling rationale.
Jiyeon Kim
Comment 7 2012-11-01 00:38:13 PDT
(In reply to comment #6) > (From update of attachment 169822 [details]) > > I also have a plan to make some apis for getting disk usage of local storage and application cache. > > These also don't need to be signed. r-, since there is no compelling rationale. Is there any way better to get/set application cache quota? I think I have two options. First, change the type of quota int64 to uint64 in webcore. Second, just use casting value for webkit2 api. Would you give me some advice about quota value?
Note You need to log in before you can comment on or make changes to this bug.