Bug 99930

Summary: [EFL][WK2] Make Ewk_Cookie_Manager members private
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99696    
Attachments:
Description Flags
Patch
kenneth: review+
Patch for landing
none
Patch for landing none

Chris Dumez
Reported 2012-10-21 06:07:19 PDT
As part of Bug 99696, this bug is for making the Ewk_Cookie_Manager class members private.
Attachments
Patch (14.03 KB, patch)
2012-10-21 06:30 PDT, Chris Dumez 		kenneth: review+
DetailsFormatted DiffDiff
Patch for landing (14.03 KB, patch)
2012-10-21 07:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.04 KB, patch)
2012-10-21 07:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-21 06:30:48 PDT
Created attachment 169796 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-10-21 07:40:06 PDT
Comment on attachment 169796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169796&action=review > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:121 > +// Ewk_Cookie_Persistent_Storage enum validation dot at end? :) > Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:133 > +// Ewk_Cookie_Accept_Policy enum validation Same
Chris Dumez
Comment 3 2012-10-21 07:51:12 PDT
Created attachment 169800 [details] Patch for landing Fix nits spotted by Kenneth.
Chris Dumez
Comment 4 2012-10-21 07:52:27 PDT
Comment on attachment 169800 [details] Patch for landing Missing reviewer name :(
Chris Dumez
Comment 5 2012-10-21 07:53:33 PDT
Created attachment 169801 [details] Patch for landing Added missing reviewer name. Sorry about that.
WebKit Review Bot
Comment 6 2012-10-21 09:00:39 PDT
Comment on attachment 169801 [details] Patch for landing Clearing flags on attachment: 169801 Committed r132002: <http://trac.webkit.org/changeset/132002>
WebKit Review Bot
Comment 7 2012-10-21 09:00:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.