Bug 99930 - [EFL][WK2] Make Ewk_Cookie_Manager members private
Summary: [EFL][WK2] Make Ewk_Cookie_Manager members private
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 99696
  Show dependency tree / graph
 
Reported: 2012-10-21 06:07 PDT by Chris Dumez
Modified: 2012-10-21 09:00 PDT (History)
7 users (show)

See Also:

Attachments
Patch (14.03 KB, patch)
2012-10-21 06:30 PDT, Chris Dumez 		kenneth: review+
Details | Formatted Diff | Diff
Patch for landing (14.03 KB, patch)
2012-10-21 07:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch for landing (14.04 KB, patch)
2012-10-21 07:53 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-21 06:07:19 PDT 
As part of Bug 99696, this bug is for making the Ewk_Cookie_Manager class members private.
Comment 1 Chris Dumez 2012-10-21 06:30:48 PDT 
Created attachment 169796 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-10-21 07:40:06 PDT 
Comment on attachment 169796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169796&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:121
> +// Ewk_Cookie_Persistent_Storage enum validation

dot at end? :)

> Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp:133
> +// Ewk_Cookie_Accept_Policy enum validation

Same
Comment 3 Chris Dumez 2012-10-21 07:51:12 PDT 
Created attachment 169800 [details]
Patch for landing

Fix nits spotted by Kenneth.
Comment 4 Chris Dumez 2012-10-21 07:52:27 PDT 
Comment on attachment 169800 [details]
Patch for landing

Missing reviewer name :(
Comment 5 Chris Dumez 2012-10-21 07:53:33 PDT 
Created attachment 169801 [details]
Patch for landing

Added missing reviewer name. Sorry about that.
Comment 6 WebKit Review Bot 2012-10-21 09:00:39 PDT 
Comment on attachment 169801 [details]
Patch for landing

Clearing flags on attachment: 169801

Committed r132002: <http://trac.webkit.org/changeset/132002>
Comment 7 WebKit Review Bot 2012-10-21 09:00:44 PDT 
All reviewed patches have been landed.  Closing bug.