| Summary: | [CSS] shadow from radius has wrong render in webkit | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | 胡伟松 <weisong4413> | ||||||||||||||||
| Component: | CSS | Assignee: | Takashi Sakamoto <tasak> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | dglazkov, morrita, simon.fraser, syoichi, tasak, webkit.review.bot | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||
| Bug Blocks: | 27569 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
胡伟松
2012-10-21 02:40:46 PDT
render results of box shadow. please pay attention at the conner of the shadow Created attachment 169792 [details]
results in most browsers
the wrong results of shadow
Created attachment 169793 [details]
test case of shadow
Created attachment 173203 [details]
Patch
Created attachment 179890 [details]
Patch
Comment on attachment 179890 [details] Patch Attachment 179890 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15413089 New failing tests: fast/frames/sandboxed-iframe-attribute-parsing.html Created attachment 191453 [details]
Patch
Comment on attachment 191453 [details] Patch Attachment 191453 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17025144 New failing tests: fast/borders/border-radius-with-box-shadow.html Comment on attachment 191453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191453&action=review > Source/WebCore/ChangeLog:10 > + corners are rounded, but others are not rounded. Need to see each > + corners, i.e. top-left, top-right, bottom-left and bottom-right, and I think you're trying to say "Need to look at each corner independently". Created attachment 191608 [details]
Patch for landing
Comment on attachment 191453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191453&action=review Thank you for reviewing. I checked the new failing: fast/borders/border-radius-with-box-shadow and found that its actual image looked almost the same as its expected image. So I would like to rebaseline. >> Source/WebCore/ChangeLog:10 >> + corners, i.e. top-left, top-right, bottom-left and bottom-right, and > > I think you're trying to say "Need to look at each corner independently". Thanks. Done. Attachment 191608 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/box-shadow/box-shadow-with-zero-radius-expected.html', u'LayoutTests/fast/box-shadow/box-shadow-with-zero-radius.html', u'LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/RoundedRect.cpp']" exit_code: 1
LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 192631 [details]
Patch
Comment on attachment 192631 [details] Patch Clearing flags on attachment: 192631 Committed r145474: <http://trac.webkit.org/changeset/145474> All reviewed patches have been landed. Closing bug. |