Bug 99885

Summary: WebProcess should only connect to the NetworkProcess if NetworkProcess is enabled
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 98537    
Attachments:
Description Flags
Patch v1
none
Patch v2 ap: review+

Brady Eidson
Reported 2012-10-19 16:33:10 PDT
WebProcess should only connect to the NetworkProcess if NetworkProcess is enabled
Attachments
Patch v1 (5.44 KB, patch)
2012-10-19 16:35 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 (5.36 KB, patch)
2012-10-19 16:44 PDT, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-10-19 16:35:43 PDT
Created attachment 169720 [details] Patch v1
Alexey Proskuryakov
Comment 2 2012-10-19 16:38:47 PDT
Comment on attachment 169720 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=169720&action=review > Source/WebKit2/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). ! > Source/WebKit2/ChangeLog:28 > + (WebProcess): prepare-ChangeLog does this to us, but it should be corrected manually when generated ChangeLog doesn't make sense.. > Source/WebKit2/Shared/WebProcessCreationParameters.cpp:50 > + , shouldUseNetworkProcess(false) I'm not a fan of this name. We are going to not use NetworkProcess for local files, so this "should" is way too strong.
Brady Eidson
Comment 3 2012-10-19 16:44:14 PDT
Created attachment 169721 [details] Patch v2
Alexey Proskuryakov
Comment 4 2012-10-19 16:45:48 PDT
Comment on attachment 169721 [details] Patch v2 r=me. We will also need a way to change this in WebProcess dynamically, I think.
Brady Eidson
Comment 5 2012-10-19 16:48:37 PDT
(In reply to comment #4) > (From update of attachment 169721 [details]) > r=me. We will also need a way to change this in WebProcess dynamically, I think. Currently we treat "flipping the switch" as a "you must quit and restart" situation. It certainly might be desirable to add the ability to dynamically change it, and shouldn't be too complex to do so in the future. Thanks for the review!
Brady Eidson
Comment 6 2012-10-19 17:00:46 PDT
http://trac.webkit.org/changeset/131963
Note You need to log in before you can comment on or make changes to this bug.