Bug 99877

Summary: [chromium] Remove static create functions from types WebCompositorSupport can construct
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, dglazkov, enne, eric.carlson, feature-media-reviews, fishd, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

James Robinson
Reported 2012-10-19 14:57:51 PDT
[chromium] Remove static create functions from types WebCompositorSupport can construct
Attachments
Patch (9.26 KB, patch)
2012-10-19 14:58 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (9.12 KB, patch)
2013-01-04 10:46 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-10-19 14:58:08 PDT
Created attachment 169700 [details] Patch
James Robinson
Comment 2 2012-10-19 14:58:26 PDT
This'll bust the build until https://codereview.chromium.org/11231017/ lands + rolls.
WebKit Review Bot
Comment 3 2012-10-19 15:03:30 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Peter Beverloo (cr-android ews)
Comment 4 2012-10-19 15:21:36 PDT
Comment on attachment 169700 [details] Patch Attachment 169700 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14455690
WebKit Review Bot
Comment 5 2012-10-19 15:28:11 PDT
Comment on attachment 169700 [details] Patch Attachment 169700 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14471217
Adrienne Walker
Comment 6 2012-10-22 12:07:50 PDT
Comment on attachment 169700 [details] Patch R=me.
James Robinson
Comment 7 2013-01-04 10:46:48 PST
Created attachment 181331 [details] Patch
WebKit Review Bot
Comment 8 2013-01-04 12:27:00 PST
Comment on attachment 181331 [details] Patch Clearing flags on attachment: 181331 Committed r138831: <http://trac.webkit.org/changeset/138831>
WebKit Review Bot
Comment 9 2013-01-04 12:27:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.