Bug 99853

Summary: Don't use CStrings for message receiver names and message names
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, gyuyoung.kim, menard, rakuco, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 99871    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch kling: review+

Anders Carlsson
Reported 2012-10-19 10:45:33 PDT
Don't use CStrings for message receiver names and message names
Attachments
Patch (47.38 KB, patch)
2012-10-19 11:04 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (48.03 KB, patch)
2012-10-19 11:17 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (48.05 KB, patch)
2012-10-19 11:24 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-19 11:04:41 PDT
Created attachment 169651 [details] Patch
WebKit Review Bot
Comment 2 2012-10-19 11:07:39 PDT
Attachment 169651 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:194: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2012-10-19 11:17:59 PDT
Created attachment 169655 [details] Patch
WebKit Review Bot
Comment 4 2012-10-19 11:20:50 PDT
Attachment 169655 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:194: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 5 2012-10-19 11:24:17 PDT
Created attachment 169659 [details] Patch
WebKit Review Bot
Comment 6 2012-10-19 11:28:21 PDT
Attachment 169659 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/Platform/CoreIPC/Connection.h:194: Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html). [readability/pass_ptr] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 7 2012-10-19 12:28:26 PDT
Committed r131931: <http://trac.webkit.org/changeset/131931>
WebKit Review Bot
Comment 8 2012-10-19 14:29:57 PDT
Re-opened since this is blocked by bug 99871
Simon Fraser (smfr)
Comment 9 2012-10-19 14:31:33 PDT
This broke Safari extensions (Adblock started to block all CSS files, causing sites to render with no style). Rolling out.
Anders Carlsson
Comment 10 2012-10-22 08:58:52 PDT
Great.
Anders Carlsson
Comment 11 2012-10-22 09:55:15 PDT
Committed r132085: <http://trac.webkit.org/changeset/132085>
Note You need to log in before you can comment on or make changes to this bug.