Bug 99845

Summary: Remove devicePixelRatio from ViewportAttributes
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: New BugsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, dglazkov, gyuyoung.kim, kenneth, kpiascik, menard, mifenton, peter+ews, rakuco, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Andras Becsi
Reported 2012-10-19 09:18:11 PDT
Remove devicePixelRatio from ViewportAttributes
Attachments
Patch (21.24 KB, patch)
2012-10-19 09:24 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.09 KB, patch)
2012-10-22 05:10 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Patch (27.38 KB, patch)
2012-10-22 07:01 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2012-10-19 09:24:23 PDT
Created attachment 169633 [details] Patch
WebKit Review Bot
Comment 2 2012-10-19 09:26:08 PDT
Attachment 169633 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1 Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:697: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 3 2012-10-19 09:34:58 PDT
Thanks, that looks great.
Andras Becsi
Comment 4 2012-10-19 09:38:53 PDT
(In reply to comment #3) > Thanks, that looks great. Thanks, waiting for the EWS to process the patch.
Build Bot
Comment 5 2012-10-19 09:57:38 PDT
Comment on attachment 169633 [details] Patch Attachment 169633 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14466464
WebKit Review Bot
Comment 6 2012-10-19 10:03:57 PDT
Comment on attachment 169633 [details] Patch Attachment 169633 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14461496
Peter Beverloo (cr-android ews)
Comment 7 2012-10-19 10:14:52 PDT
Comment on attachment 169633 [details] Patch Attachment 169633 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14471092
Gyuyoung Kim
Comment 8 2012-10-19 10:15:17 PDT
Comment on attachment 169633 [details] Patch Attachment 169633 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14464498
Andras Becsi
Comment 9 2012-10-22 05:10:39 PDT
Created attachment 169880 [details] Patch for landing
WebKit Review Bot
Comment 10 2012-10-22 05:12:37 PDT
Attachment 169880 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1 Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:697: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andras Becsi
Comment 11 2012-10-22 05:12:48 PDT
Comment on attachment 169880 [details] Patch for landing Letting the EWS' process the patch.
EFL EWS Bot
Comment 12 2012-10-22 05:42:17 PDT
Comment on attachment 169880 [details] Patch for landing Attachment 169880 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14491458
Andras Becsi
Comment 13 2012-10-22 07:01:44 PDT
Created attachment 169901 [details] Patch Try to fix the EFL build.
WebKit Review Bot
Comment 14 2012-10-22 07:04:13 PDT
Attachment 169901 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1 Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:697: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andras Becsi
Comment 15 2012-10-23 02:15:21 PDT
Comment on attachment 169901 [details] Patch Clearing flags on attachment: 169901 Committed r132193: <http://trac.webkit.org/changeset/132193>
Andras Becsi
Comment 16 2012-10-23 02:15:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.