Bug 99813

Summary: Move ConnectionStack out of WebProcessConnection into its own files
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, andersca, ap, cmarcelo, gyuyoung.kim, menard, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 kling: review+

Brady Eidson
Reported 2012-10-18 23:17:59 PDT
Move ConnectionStack out of WebProcessConnection into its own files
Attachments
Patch v1 (16.15 KB, patch)
2012-10-18 23:20 PDT, Brady Eidson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-10-18 23:20:49 PDT
Created attachment 169556 [details] Patch v1
WebKit Review Bot
Comment 2 2012-10-18 23:23:29 PDT
Attachment 169556 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/Shared/ConnectionStack.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2012-10-18 23:26:56 PDT
Comment on attachment 169556 [details] Patch v1 r=me
mitz
Comment 4 2012-10-18 23:30:11 PDT
Comment on attachment 169556 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=169556&action=review > Source/WebKit2/Shared/ConnectionStack.cpp:2 > + * Copyright (C) 2012 Apple Inc. All rights reserved. Did this code first appear in 2012? The file it comes from says 2010.
Brady Eidson
Comment 5 2012-10-18 23:34:31 PDT
(In reply to comment #4) > (From update of attachment 169556 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169556&action=review > > > Source/WebKit2/Shared/ConnectionStack.cpp:2 > > + * Copyright (C) 2012 Apple Inc. All rights reserved. > > Did this code first appear in 2012? The file it comes from says 2010. Researched and amended. Thanks for pointing that out. Landed in http://trac.webkit.org/changeset/131861
Note You need to log in before you can comment on or make changes to this bug.