Bug 99783

Summary: [V8] fast/dom/gc-9.html fails for document.implementation
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dcarney, eric, esprehn, haraken, japhet, jochen, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99786    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-10-18 18:01:52 PDT
[V8] fast/dom/gc-9.html fails for document.implementation
Attachments
Patch (12.15 KB, patch)
2012-10-18 18:03 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-10-18 18:03:51 PDT
Created attachment 169523 [details] Patch
Kentaro Hara
Comment 2 2012-10-18 18:07:04 PDT
Comment on attachment 169523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169523&action=review Looks reasonable. > LayoutTests/platform/chromium/fast/dom/gc-9-expected.txt:8 > +PASS: document.implementation.myCustomProperty should be 1 and is. Looks fine. > LayoutTests/platform/chromium/fast/dom/gc-9-expected.txt:49 > +FAIL: document.getElementsByTagName('canvas')[0].getContext('2d').myCustomProperty should be 1 but instead is undefined. Just a confirmation: Are a bunch of FAIL lines in the expected result intended?
Adam Barth
Comment 3 2012-10-18 18:16:56 PDT
(In reply to comment #2) > (From update of attachment 169523 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169523&action=review > > > LayoutTests/platform/chromium/fast/dom/gc-9-expected.txt:49 > > +FAIL: document.getElementsByTagName('canvas')[0].getContext('2d').myCustomProperty should be 1 but instead is undefined. > > Just a confirmation: Are a bunch of FAIL lines in the expected result intended? Yes. I will fix them in separate patches.
WebKit Review Bot
Comment 4 2012-10-18 18:53:09 PDT
Comment on attachment 169523 [details] Patch Clearing flags on attachment: 169523 Committed r131838: <http://trac.webkit.org/changeset/131838>
WebKit Review Bot
Comment 5 2012-10-18 18:53:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.