Bug 99775

Summary: Build fix after r131741 for !ENABLE(CSS_SHADERS) platforms
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98733    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Dongseong Hwang
Reported 2012-10-18 16:38:16 PDT
Remove "using namespace WebKit;" in CoordinatedGraphicsArgumentCoders because WebKit namespace is only used when ENABLE(CSS_SHADERS). It is because build fails when disabling CSS_SHADERS. For example, it brokes the Qt --minimal build.
Attachments
Patch (2.09 KB, patch)
2012-10-18 16:41 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2012-10-19 02:05 PDT, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-10-18 16:41:37 PDT
Created attachment 169505 [details] Patch
Alexey Proskuryakov
Comment 2 2012-10-18 22:33:10 PDT
Comment on attachment 169505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169505&action=review > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:-66 > -using namespace WebKit; I suggest just putting this inside an ifdef, too. The namespace prefix you are adding below is quite mysterious.
Csaba Osztrogonác
Comment 3 2012-10-19 00:02:23 PDT
Comment on attachment 169505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169505&action=review > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:259 > + RefPtr<CustomFilterProgram> program = WebKit::WebCustomFilterProgram::create(vertexShaderString, fragmentShaderString, programType, mixSettings); If WebKit isn't valid namespace, I don't think if WebKit::WebCustomFilterProgram::create is valid function name.
Csaba Osztrogonác
Comment 4 2012-10-19 01:56:19 PDT
Comment on attachment 169505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169505&action=review >> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:259 >> + RefPtr<CustomFilterProgram> program = WebKit::WebCustomFilterProgram::create(vertexShaderString, fragmentShaderString, programType, mixSettings); > > If WebKit isn't valid namespace, I don't think if WebKit::WebCustomFilterProgram::create is valid function name. I didn't say anything, this code is ENABLE(CSS_SHADERS) guarded.
Dongseong Hwang
Comment 5 2012-10-19 02:05:29 PDT
Created attachment 169579 [details] Patch
Dongseong Hwang
Comment 6 2012-10-19 02:07:07 PDT
(In reply to comment #2) > I suggest just putting this inside an ifdef, too. The namespace prefix you are adding below is quite mysterious. (In reply to comment #4) > I didn't say anything, this code is ENABLE(CSS_SHADERS) guarded. Thanks for advices. I guard this namespace code by ENABLE(CSS_SHADERS) as you suggested.
Csaba Osztrogonác
Comment 7 2012-10-19 02:43:30 PDT
Comment on attachment 169579 [details] Patch Clearing flags on attachment: 169579 Committed r131878: <http://trac.webkit.org/changeset/131878>
Csaba Osztrogonác
Comment 8 2012-10-19 02:43:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.