Bug 99744

Summary: [Qt] Get rid of QQuickWebView::setRenderToOffscreenBuffer
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abecsi, cmarcelo, jturcotte, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jturcotte: review-

Balazs Kelemen
Reported 2012-10-18 12:02:55 PDT
With the recent changes for pixel testing (r131725 and r131726) we actually do rendering in the UI process when running the tests, so we don't need this workaround anymore.
Attachments
Patch (5.90 KB, patch)
2012-10-18 12:05 PDT, Balazs Kelemen 		jturcotte: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2012-10-18 12:05:57 PDT
Created attachment 169447 [details] Patch
Jocelyn Turcotte
Comment 2 2012-10-19 01:40:03 PDT
Comment on attachment 169447 [details] Patch See https://bugs.webkit.org/show_bug.cgi?id=76708 This wasn't needed to get the pixels but to make sure that the rendering queue in LayerTreeRenderer doesn't fill up when the window isn't shown. See that we're still using a 1x1 image. Since we only enable the rendering for pixel tests, I believe that we still need that code for the rest.
Balazs Kelemen
Comment 3 2012-10-19 05:11:53 PDT
Abandoning this in favor of bug 99831.
Note You need to log in before you can comment on or make changes to this bug.