Bug 99727

Summary:

Make conversion between JSStringRef and WKStringRef work without character size conversions

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

WebKit API

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

roger_fong, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	andersca: review+, gyuyoung.kim: commit-queue-
Patch with fix to #include typo	none

Michael Saboff

Reported 2012-10-18 09:42:27 PDT

The APIs WKStringRef WKStringCreateWithJSString(JSStringRef) and JSStringRef WKStringCopyJSString(WKStringRef) call the characters() method on their argument string to create the wrapped return string. This will cause 8-bit argument string to be up converted and create the results strings as 16 bit strings. Instead both of these API's should use the wrapped WTFString objects so that 8-bit strings stay that way. Due to threading, these API's need to create copies, but that is already done in OpaqueJSString.

Attachments
Patch (3.39 KB, patch) 2012-10-18 09:54 PDT, Michael Saboff	andersca: review+ gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
Patch with fix to #include typo (3.39 KB, patch) 2012-10-18 10:18 PDT, Michael Saboff	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.